Checkstyle Results

The following document contains the results of Checkstyle 8.40 with org/wikimedia/discovery/build/tools/checkstyle/checkstyle.xml ruleset. 

Summary

Files	Info	Warnings	Errors
33	0	0	74

Files

File	I	W	E
org/wikimedia/gobblin/converter/TimestampedRecordConverterWrapper.java	0	0	1
org/wikimedia/gobblin/copy/BaseDataPublisher.java	0	0	12
org/wikimedia/gobblin/copy/Kafka1ConsumerClient.java	0	0	25
org/wikimedia/gobblin/copy/KafkaSource.java	0	0	29
org/wikimedia/gobblin/kafka/Kafka1TimestampedRecordExtractor.java	0	0	1
org/wikimedia/gobblin/kafka/WikimediaKafkaSource.java	0	0	1
org/wikimedia/gobblin/publisher/TimePartitionedFlagDataPublisher.java	0	0	1
org/wikimedia/gobblin/utils/JsonStringTimestampExtractor.java	0	0	4

Rules

Category	Rule	Violations	Severity
blocks	RightCurly	1	Error
coding	ExplicitInitialization	12	Error
	IllegalCatch	8	Error
	MissingSwitchDefault	2	Error
imports	AvoidStarImport	6	Error
	ImportOrder ordered: "false" sortStaticImportsAlphabetically: "true" caseSensitive: "false" groups: "/^java\./,javax,org,com," separated: "true" option: "top"	3	Error
	UnusedImports	2	Error
javadoc	JavadocStyle	10	Error
metrics	ClassFanOutComplexity max: "25" id: "checkstyle:classfanoutcomplexity"	3	Error
	CyclomaticComplexity	5	Error
	NPathComplexity	2	Error
misc	NewlineAtEndOfFile	2	Error
	UpperEll	1	Error
sizes	LineLength max: "160"	8	Error
whitespace	NoWhitespaceBefore	2	Error
	WhitespaceAfter tokens: "COMMA, SEMI"	2	Error
	WhitespaceAround allowEmptyConstructors: "true" allowEmptyLambdas: "true" allowEmptyMethods: "true" allowEmptyLoops: "true" tokens: "ASSIGN, BAND, BAND_ASSIGN, BOR, BOR_ASSIGN, BSR, BSR_ASSIGN, BXOR, BXOR_ASSIGN, COLON, DIV, DIV_ASSIGN, DO_WHILE, EQUAL, GE, GT, LAMBDA, LAND, LCURLY, LE, LITERAL_CATCH, LITERAL_DO, LITERAL_ELSE, LITERAL_FINALLY, LITERAL_FOR, LITERAL_IF, LITERAL_RETURN, LITERAL_SWITCH, LITERAL_SYNCHRONIZED, LITERAL_TRY, LITERAL_WHILE, LOR, LT, MINUS, MINUS_ASSIGN, MOD, MOD_ASSIGN, NOT_EQUAL, PLUS, PLUS_ASSIGN, QUESTION, RCURLY, SL, SLIST, SL_ASSIGN, SR, SR_ASSIGN, STAR_ASSIGN, LITERAL_ASSERT, TYPE_EXTENSION_AND" allowEmptyTypes: "true"	5	Error

Details

org/wikimedia/gobblin/converter/TimestampedRecordConverterWrapper.java

Severity	Category	Rule	Message	Line
Error	coding	IllegalCatch	Catching 'Exception' is not allowed.	51

org/wikimedia/gobblin/copy/BaseDataPublisher.java

Severity	Category	Rule	Message	Line
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - org.apache.gobblin.util.retry.RetryerFactory.*.	19
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - java.util.*.	25
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - org.apache.hadoop.fs.*.	52
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - com.google.common.collect.*.	58
Error	metrics	ClassFanOutComplexity	Class Fan-Out Complexity is 30 (max allowed is 25).	98
Error	whitespace	WhitespaceAround	'+' is not preceded with whitespace.	200
Error	whitespace	WhitespaceAround	'}' is not followed by whitespace.	202
Error	whitespace	WhitespaceAround	'else' is not preceded with whitespace.	202
Error	javadoc	JavadocStyle	First sentence should end with a period.	322
Error	metrics	CyclomaticComplexity	Cyclomatic Complexity is 11 (max allowed is 10).	591
Error	javadoc	JavadocStyle	First sentence should end with a period.	657
Error	javadoc	JavadocStyle	First sentence should end with a period.	773

org/wikimedia/gobblin/copy/Kafka1ConsumerClient.java

Severity	Category	Rule	Message	Line
Error	misc	NewlineAtEndOfFile	File does not end with a newline.	1
Error	imports	ImportOrder	Wrong order for 'org.apache.gobblin.configuration.ConfigurationKeys' import.	36
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - org.apache.kafka.clients.consumer.*.	47
Error	imports	ImportOrder	Wrong order for 'javax.annotation.Nonnull' import.	55
Error	imports	ImportOrder	Wrong order for 'java.io.IOException' import.	56
Error	imports	AvoidStarImport	Using the '.*' form of import should be avoided - java.util.*.	57
Error	metrics	ClassFanOutComplexity	Class Fan-Out Complexity is 29 (max allowed is 25).	79
Error	coding	IllegalCatch	Catching 'Throwable' is not allowed.	188
Error	coding	IllegalCatch	Catching 'Exception' is not allowed.	192
Error	javadoc	JavadocStyle	First sentence should end with a period.	198
Error	javadoc	JavadocStyle	First sentence should end with a period.	208
Error	sizes	LineLength	Line is longer than 160 characters (found 189).	218
Error	sizes	LineLength	Line is longer than 160 characters (found 190).	223
Error	javadoc	JavadocStyle	First sentence should end with a period.	238
Error	sizes	LineLength	Line is longer than 160 characters (found 233).	243
Error	whitespace	WhitespaceAfter	',' is not followed by whitespace.	243
Error	whitespace	WhitespaceAround	'if' is not followed by whitespace.	247
Error	javadoc	JavadocStyle	First sentence should end with a period.	255
Error	sizes	LineLength	Line is longer than 160 characters (found 233).	260
Error	whitespace	WhitespaceAfter	',' is not followed by whitespace.	260
Error	javadoc	JavadocStyle	First sentence should end with a period.	264
Error	misc	UpperEll	Should use uppercase 'L'.	272
Error	javadoc	JavadocStyle	First sentence should end with a period.	308
Error	javadoc	JavadocStyle	First sentence should end with a period.	319
Error	whitespace	NoWhitespaceBefore	',' is preceded with whitespace.	334

org/wikimedia/gobblin/copy/KafkaSource.java

Severity	Category	Rule	Message	Line
Error	misc	NewlineAtEndOfFile	File does not end with a newline.	1
Error	metrics	ClassFanOutComplexity	Class Fan-Out Complexity is 35 (max allowed is 25).	97
Error	coding	ExplicitInitialization	Variable 'sharedKafkaConsumerClient' explicitly initialized to 'null' (default value for its type).	172
Error	coding	ExplicitInitialization	Variable 'doneGettingAllPreviousOffsets' explicitly initialized to 'false' (default value for its type).	176
Error	metrics	CyclomaticComplexity	Cyclomatic Complexity is 13 (max allowed is 10).	206
Error	metrics	NPathComplexity	NPath Complexity is 489 (max allowed is 200).	206
Error	whitespace	WhitespaceAround	'if' is not followed by whitespace.	292
Error	coding	IllegalCatch	Catching 'Throwable' is not allowed.	305
Error	coding	IllegalCatch	Catching 'Throwable' is not allowed.	317
Error	metrics	CyclomaticComplexity	Cyclomatic Complexity is 24 (max allowed is 10).	436
Error	metrics	NPathComplexity	NPath Complexity is 576 (max allowed is 200).	436
Error	coding	IllegalCatch	Catching 'Throwable' is not allowed.	446
Error	whitespace	NoWhitespaceBefore	',' is preceded with whitespace.	503
Error	sizes	LineLength	Line is longer than 160 characters (found 175).	506
Error	blocks	RightCurly	'}' at column 13 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally).	538
Error	sizes	LineLength	Line is longer than 160 characters (found 173).	592
Error	sizes	LineLength	Line is longer than 160 characters (found 171).	594
Error	sizes	LineLength	Line is longer than 160 characters (found 162).	601
Error	coding	ExplicitInitialization	Variable 'startOffset' explicitly initialized to '0' (default value for its type).	832
Error	coding	ExplicitInitialization	Variable 'earliestOffset' explicitly initialized to '0' (default value for its type).	836
Error	coding	ExplicitInitialization	Variable 'latestOffset' explicitly initialized to '0' (default value for its type).	840
Error	coding	ExplicitInitialization	Variable 'offsetFetchEpochTime' explicitly initialized to '0' (default value for its type).	844
Error	coding	ExplicitInitialization	Variable 'previousOffsetFetchEpochTime' explicitly initialized to '0' (default value for its type).	848
Error	coding	ExplicitInitialization	Variable 'previousLatestOffset' explicitly initialized to '0' (default value for its type).	852
Error	coding	ExplicitInitialization	Variable 'previousStartOffset' explicitly initialized to '0' (default value for its type).	857
Error	coding	ExplicitInitialization	Variable 'previousEndOffset' explicitly initialized to '0' (default value for its type).	862
Error	coding	ExplicitInitialization	Variable 'previousStartFetchEpochTime' explicitly initialized to '0' (default value for its type).	866
Error	coding	ExplicitInitialization	Variable 'previousStopFetchEpochTime' explicitly initialized to '0' (default value for its type).	870
Error	coding	IllegalCatch	Catching 'Throwable' is not allowed.	920

org/wikimedia/gobblin/kafka/Kafka1TimestampedRecordExtractor.java

Severity	Category	Rule	Message	Line
Error	imports	UnusedImports	Unused import - java.util.List.	21

org/wikimedia/gobblin/kafka/WikimediaKafkaSource.java

Severity	Category	Rule	Message	Line
Error	imports	UnusedImports	Unused import - java.util.stream.Collectors.	28

org/wikimedia/gobblin/publisher/TimePartitionedFlagDataPublisher.java

Severity	Category	Rule	Message	Line
Error	metrics	CyclomaticComplexity	Cyclomatic Complexity is 11 (max allowed is 10).	128

org/wikimedia/gobblin/utils/JsonStringTimestampExtractor.java

Severity	Category	Rule	Message	Line
Error	metrics	CyclomaticComplexity	Cyclomatic Complexity is 11 (max allowed is 10).	81
Error	coding	MissingSwitchDefault	switch without "default" clause.	96
Error	coding	MissingSwitchDefault	switch without "default" clause.	105
Error	coding	IllegalCatch	Catching 'Exception' is not allowed.	113