The following document contains the results of Checkstyle 8.40 with org/wikimedia/discovery/build/tools/checkstyle/checkstyle.xml ruleset.
Files | ![]() |
![]() |
![]() |
---|---|---|---|
8 | 0 | 0 | 74 |
Category | Rule | Violations | Severity |
---|---|---|---|
blocks | RightCurly | 1 | ![]() |
coding | ExplicitInitialization | 12 | ![]() |
IllegalCatch | 8 | ![]() | |
MissingSwitchDefault | 2 | ![]() | |
imports | AvoidStarImport | 6 | ![]() |
ImportOrder
|
3 | ![]() | |
UnusedImports | 2 | ![]() | |
javadoc | JavadocStyle | 10 | ![]() |
metrics | ClassFanOutComplexity
|
3 | ![]() |
CyclomaticComplexity | 5 | ![]() | |
NPathComplexity | 2 | ![]() | |
misc | NewlineAtEndOfFile | 2 | ![]() |
UpperEll | 1 | ![]() | |
sizes | LineLength
|
8 | ![]() |
whitespace | NoWhitespaceBefore | 2 | ![]() |
WhitespaceAfter
|
2 | ![]() | |
WhitespaceAround
|
5 | ![]() |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 51 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.apache.gobblin.util.retry.RetryerFactory.*. | 19 |
![]() |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 25 |
![]() |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.apache.hadoop.fs.*. | 52 |
![]() |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - com.google.common.collect.*. | 58 |
![]() |
metrics | ClassFanOutComplexity | Class Fan-Out Complexity is 30 (max allowed is 25). | 98 |
![]() |
whitespace | WhitespaceAround | '+' is not preceded with whitespace. | 200 |
![]() |
whitespace | WhitespaceAround | '}' is not followed by whitespace. | 202 |
![]() |
whitespace | WhitespaceAround | 'else' is not preceded with whitespace. | 202 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 322 |
![]() |
metrics | CyclomaticComplexity | Cyclomatic Complexity is 11 (max allowed is 10). | 591 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 657 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 773 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
![]() |
imports | ImportOrder | Wrong order for 'org.apache.gobblin.configuration.ConfigurationKeys' import. | 36 |
![]() |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - org.apache.kafka.clients.consumer.*. | 47 |
![]() |
imports | ImportOrder | Wrong order for 'javax.annotation.Nonnull' import. | 55 |
![]() |
imports | ImportOrder | Wrong order for 'java.io.IOException' import. | 56 |
![]() |
imports | AvoidStarImport | Using the '.*' form of import should be avoided - java.util.*. | 57 |
![]() |
metrics | ClassFanOutComplexity | Class Fan-Out Complexity is 29 (max allowed is 25). | 79 |
![]() |
coding | IllegalCatch | Catching 'Throwable' is not allowed. | 188 |
![]() |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 192 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 198 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 208 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 189). | 218 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 190). | 223 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 238 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 233). | 243 |
![]() |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 243 |
![]() |
whitespace | WhitespaceAround | 'if' is not followed by whitespace. | 247 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 255 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 233). | 260 |
![]() |
whitespace | WhitespaceAfter | ',' is not followed by whitespace. | 260 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 264 |
![]() |
misc | UpperEll | Should use uppercase 'L'. | 272 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 308 |
![]() |
javadoc | JavadocStyle | First sentence should end with a period. | 319 |
![]() |
whitespace | NoWhitespaceBefore | ',' is preceded with whitespace. | 334 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
misc | NewlineAtEndOfFile | File does not end with a newline. | 1 |
![]() |
metrics | ClassFanOutComplexity | Class Fan-Out Complexity is 35 (max allowed is 25). | 97 |
![]() |
coding | ExplicitInitialization | Variable 'sharedKafkaConsumerClient' explicitly initialized to 'null' (default value for its type). | 172 |
![]() |
coding | ExplicitInitialization | Variable 'doneGettingAllPreviousOffsets' explicitly initialized to 'false' (default value for its type). | 176 |
![]() |
metrics | CyclomaticComplexity | Cyclomatic Complexity is 13 (max allowed is 10). | 206 |
![]() |
metrics | NPathComplexity | NPath Complexity is 489 (max allowed is 200). | 206 |
![]() |
whitespace | WhitespaceAround | 'if' is not followed by whitespace. | 292 |
![]() |
coding | IllegalCatch | Catching 'Throwable' is not allowed. | 305 |
![]() |
coding | IllegalCatch | Catching 'Throwable' is not allowed. | 317 |
![]() |
metrics | CyclomaticComplexity | Cyclomatic Complexity is 24 (max allowed is 10). | 436 |
![]() |
metrics | NPathComplexity | NPath Complexity is 576 (max allowed is 200). | 436 |
![]() |
coding | IllegalCatch | Catching 'Throwable' is not allowed. | 446 |
![]() |
whitespace | NoWhitespaceBefore | ',' is preceded with whitespace. | 503 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 175). | 506 |
![]() |
blocks | RightCurly | '}' at column 13 should be on the same line as the next part of a multi-block statement (one that directly contains multiple blocks: if/else-if/else, do/while or try/catch/finally). | 538 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 173). | 592 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 171). | 594 |
![]() |
sizes | LineLength | Line is longer than 160 characters (found 162). | 601 |
![]() |
coding | ExplicitInitialization | Variable 'startOffset' explicitly initialized to '0' (default value for its type). | 832 |
![]() |
coding | ExplicitInitialization | Variable 'earliestOffset' explicitly initialized to '0' (default value for its type). | 836 |
![]() |
coding | ExplicitInitialization | Variable 'latestOffset' explicitly initialized to '0' (default value for its type). | 840 |
![]() |
coding | ExplicitInitialization | Variable 'offsetFetchEpochTime' explicitly initialized to '0' (default value for its type). | 844 |
![]() |
coding | ExplicitInitialization | Variable 'previousOffsetFetchEpochTime' explicitly initialized to '0' (default value for its type). | 848 |
![]() |
coding | ExplicitInitialization | Variable 'previousLatestOffset' explicitly initialized to '0' (default value for its type). | 852 |
![]() |
coding | ExplicitInitialization | Variable 'previousStartOffset' explicitly initialized to '0' (default value for its type). | 857 |
![]() |
coding | ExplicitInitialization | Variable 'previousEndOffset' explicitly initialized to '0' (default value for its type). | 862 |
![]() |
coding | ExplicitInitialization | Variable 'previousStartFetchEpochTime' explicitly initialized to '0' (default value for its type). | 866 |
![]() |
coding | ExplicitInitialization | Variable 'previousStopFetchEpochTime' explicitly initialized to '0' (default value for its type). | 870 |
![]() |
coding | IllegalCatch | Catching 'Throwable' is not allowed. | 920 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | UnusedImports | Unused import - java.util.List. | 21 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
imports | UnusedImports | Unused import - java.util.stream.Collectors. | 28 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
metrics | CyclomaticComplexity | Cyclomatic Complexity is 11 (max allowed is 10). | 128 |
Severity | Category | Rule | Message | Line |
---|---|---|---|---|
![]() |
metrics | CyclomaticComplexity | Cyclomatic Complexity is 11 (max allowed is 10). | 81 |
![]() |
coding | MissingSwitchDefault | switch without "default" clause. | 96 |
![]() |
coding | MissingSwitchDefault | switch without "default" clause. | 105 |
![]() |
coding | IllegalCatch | Catching 'Exception' is not allowed. | 113 |