Code Coverage |
||||||||||
Lines |
Functions and Methods |
Classes and Traits |
||||||||
| Total | |
49.57% |
57 / 115 |
|
20.00% |
1 / 5 |
CRAP | |
0.00% |
0 / 1 |
| DoubleRedirectJob | |
50.00% |
57 / 114 |
|
20.00% |
1 / 5 |
126.00 | |
0.00% |
0 / 1 |
| __construct | |
100.00% |
5 / 5 |
|
100.00% |
1 / 1 |
1 | |||
| fixRedirects | |
0.00% |
0 / 32 |
|
0.00% |
0 / 1 |
42 | |||
| run | |
59.09% |
26 / 44 |
|
0.00% |
0 / 1 |
21.86 | |||
| getFinalDestination | |
88.89% |
24 / 27 |
|
0.00% |
0 / 1 |
5.03 | |||
| getUser | |
33.33% |
2 / 6 |
|
0.00% |
0 / 1 |
8.74 | |||
| 1 | <?php |
| 2 | /** |
| 3 | * @license GPL-2.0-or-later |
| 4 | * @file |
| 5 | */ |
| 6 | |
| 7 | namespace MediaWiki\JobQueue\Jobs; |
| 8 | |
| 9 | use MediaWiki\JobQueue\Job; |
| 10 | use MediaWiki\Linker\LinkTarget; |
| 11 | use MediaWiki\MediaWikiServices; |
| 12 | use MediaWiki\Page\CacheKeyHelper; |
| 13 | use MediaWiki\Page\PageReference; |
| 14 | use MediaWiki\Page\WikiPageFactory; |
| 15 | use MediaWiki\Parser\MagicWordFactory; |
| 16 | use MediaWiki\Revision\RevisionLookup; |
| 17 | use MediaWiki\Revision\SlotRecord; |
| 18 | use MediaWiki\Title\Title; |
| 19 | use MediaWiki\User\User; |
| 20 | use Wikimedia\Rdbms\IDBAccessObject; |
| 21 | |
| 22 | /** |
| 23 | * Fix any double redirects after moving a page. |
| 24 | * |
| 25 | * @ingroup JobQueue |
| 26 | */ |
| 27 | class DoubleRedirectJob extends Job { |
| 28 | /** |
| 29 | * @var int Max number of double redirect jobs counter. |
| 30 | * This is meant to avoid excessive memory usage. This is |
| 31 | * also used in fixDoubleRedirects.php script. |
| 32 | */ |
| 33 | public const MAX_DR_JOBS_COUNTER = 10000; |
| 34 | |
| 35 | /** @var Title The title which has changed, redirects pointing to this |
| 36 | * title are fixed |
| 37 | */ |
| 38 | private $redirTitle; |
| 39 | |
| 40 | /** @var User */ |
| 41 | private static $user; |
| 42 | |
| 43 | /** @var RevisionLookup */ |
| 44 | private $revisionLookup; |
| 45 | |
| 46 | /** @var MagicWordFactory */ |
| 47 | private $magicWordFactory; |
| 48 | |
| 49 | /** @var WikiPageFactory */ |
| 50 | private $wikiPageFactory; |
| 51 | |
| 52 | /** |
| 53 | * @param PageReference $page |
| 54 | * @param array $params Expected to contain these elements: |
| 55 | * - 'redirTitle' => string The title that changed and should be fixed. |
| 56 | * - 'reason' => string Reason for the change, can be "move" or "maintenance". Used as a suffix |
| 57 | * for the message keys "double-redirect-fixed-move" and |
| 58 | * "double-redirect-fixed-maintenance". |
| 59 | * ] |
| 60 | * @param RevisionLookup $revisionLookup |
| 61 | * @param MagicWordFactory $magicWordFactory |
| 62 | * @param WikiPageFactory $wikiPageFactory |
| 63 | */ |
| 64 | public function __construct( |
| 65 | PageReference $page, |
| 66 | array $params, |
| 67 | RevisionLookup $revisionLookup, |
| 68 | MagicWordFactory $magicWordFactory, |
| 69 | WikiPageFactory $wikiPageFactory |
| 70 | ) { |
| 71 | parent::__construct( 'fixDoubleRedirect', $page, $params ); |
| 72 | $this->redirTitle = Title::newFromText( $params['redirTitle'] ); |
| 73 | $this->revisionLookup = $revisionLookup; |
| 74 | $this->magicWordFactory = $magicWordFactory; |
| 75 | $this->wikiPageFactory = $wikiPageFactory; |
| 76 | } |
| 77 | |
| 78 | /** |
| 79 | * Insert jobs into the job queue to fix redirects to the given title |
| 80 | * @param string $reason The reason for the fix, see message |
| 81 | * "double-redirect-fixed-<reason>" |
| 82 | * @param LinkTarget $redirTitle The title which has changed, redirects |
| 83 | * pointing to this title are fixed |
| 84 | */ |
| 85 | public static function fixRedirects( $reason, $redirTitle ) { |
| 86 | # Need to use the primary DB to get the redirect table updated in the same transaction |
| 87 | $services = MediaWikiServices::getInstance(); |
| 88 | $dbw = $services->getConnectionProvider()->getPrimaryDatabase(); |
| 89 | $res = $dbw->newSelectQueryBuilder() |
| 90 | ->select( [ 'page_namespace', 'page_title' ] ) |
| 91 | ->from( 'redirect' ) |
| 92 | ->join( 'page', null, 'page_id = rd_from' ) |
| 93 | ->where( [ 'rd_namespace' => $redirTitle->getNamespace(), 'rd_title' => $redirTitle->getDBkey() ] ) |
| 94 | ->andWhere( [ 'rd_interwiki' => '' ] ) |
| 95 | ->caller( __METHOD__ )->fetchResultSet(); |
| 96 | if ( !$res->numRows() ) { |
| 97 | return; |
| 98 | } |
| 99 | $jobs = []; |
| 100 | $jobQueueGroup = $services->getJobQueueGroup(); |
| 101 | foreach ( $res as $row ) { |
| 102 | $title = Title::makeTitleSafe( $row->page_namespace, $row->page_title ); |
| 103 | if ( !$title || !$title->canExist() ) { |
| 104 | continue; |
| 105 | } |
| 106 | |
| 107 | $jobs[] = new self( |
| 108 | $title, |
| 109 | [ |
| 110 | 'reason' => $reason, |
| 111 | 'redirTitle' => $services->getTitleFormatter() |
| 112 | ->getPrefixedDBkey( $redirTitle ) |
| 113 | ], |
| 114 | $services->getRevisionLookup(), |
| 115 | $services->getMagicWordFactory(), |
| 116 | $services->getWikiPageFactory() |
| 117 | ); |
| 118 | # Avoid excessive memory usage |
| 119 | if ( count( $jobs ) > self::MAX_DR_JOBS_COUNTER ) { |
| 120 | $jobQueueGroup->push( $jobs ); |
| 121 | $jobs = []; |
| 122 | } |
| 123 | } |
| 124 | $jobQueueGroup->push( $jobs ); |
| 125 | } |
| 126 | |
| 127 | /** |
| 128 | * @return bool |
| 129 | */ |
| 130 | public function run() { |
| 131 | if ( !$this->redirTitle ) { |
| 132 | $this->setLastError( 'Invalid title' ); |
| 133 | |
| 134 | return false; |
| 135 | } |
| 136 | |
| 137 | if ( !$this->title->canExist() ) { |
| 138 | // Needs a proper title for WikiPageFactory::newFromTitle and RevisionStore::getRevisionByTitle |
| 139 | $this->setLastError( 'Cannot edit title' ); |
| 140 | |
| 141 | return false; |
| 142 | } |
| 143 | |
| 144 | $targetRev = $this->revisionLookup |
| 145 | ->getRevisionByTitle( $this->title, 0, IDBAccessObject::READ_LATEST ); |
| 146 | if ( !$targetRev ) { |
| 147 | wfDebug( __METHOD__ . ": target redirect already deleted, ignoring" ); |
| 148 | |
| 149 | return true; |
| 150 | } |
| 151 | $content = $targetRev->getContent( SlotRecord::MAIN ); |
| 152 | $currentDest = $content ? $content->getRedirectTarget() : null; |
| 153 | if ( !$currentDest || !$currentDest->equals( $this->redirTitle ) ) { |
| 154 | wfDebug( __METHOD__ . ": Redirect has changed since the job was queued" ); |
| 155 | |
| 156 | return true; |
| 157 | } |
| 158 | |
| 159 | // Check for a suppression tag (used e.g. in periodically archived discussions) |
| 160 | $mw = $this->magicWordFactory->get( 'staticredirect' ); |
| 161 | if ( $content->matchMagicWord( $mw ) ) { |
| 162 | wfDebug( __METHOD__ . ": skipping: suppressed with __STATICREDIRECT__" ); |
| 163 | |
| 164 | return true; |
| 165 | } |
| 166 | |
| 167 | // Find the current final destination |
| 168 | $newTitle = self::getFinalDestination( $this->redirTitle ); |
| 169 | if ( !$newTitle ) { |
| 170 | wfDebug( __METHOD__ . |
| 171 | ": skipping: single redirect, circular redirect or invalid redirect destination" ); |
| 172 | |
| 173 | return true; |
| 174 | } |
| 175 | if ( $newTitle->equals( $this->redirTitle ) ) { |
| 176 | // The redirect is already right, no need to change it |
| 177 | // This can happen if the page was moved back (say after vandalism) |
| 178 | wfDebug( __METHOD__ . " : skipping, already good" ); |
| 179 | } |
| 180 | |
| 181 | // Preserve fragment (T16904) |
| 182 | $newTitle = Title::makeTitle( $newTitle->getNamespace(), $newTitle->getDBkey(), |
| 183 | $currentDest->getFragment(), $newTitle->getInterwiki() ); |
| 184 | |
| 185 | // Fix the text |
| 186 | $newContent = $content->updateRedirect( $newTitle ); |
| 187 | |
| 188 | if ( $newContent->equals( $content ) ) { |
| 189 | $this->setLastError( 'Content unchanged???' ); |
| 190 | |
| 191 | return false; |
| 192 | } |
| 193 | |
| 194 | $user = $this->getUser(); |
| 195 | if ( !$user ) { |
| 196 | $this->setLastError( 'Invalid user' ); |
| 197 | |
| 198 | return false; |
| 199 | } |
| 200 | |
| 201 | $article = $this->wikiPageFactory->newFromTitle( $this->title ); |
| 202 | |
| 203 | // Messages: double-redirect-fixed-move, double-redirect-fixed-maintenance |
| 204 | $reason = wfMessage( 'double-redirect-fixed-' . $this->params['reason'], |
| 205 | $this->redirTitle->getPrefixedText(), $newTitle->getPrefixedText() |
| 206 | )->inContentLanguage()->text(); |
| 207 | // Avoid RC flood, and use minor to avoid email notifs |
| 208 | $flags = EDIT_UPDATE | EDIT_SUPPRESS_RC | EDIT_INTERNAL | EDIT_MINOR; |
| 209 | $article->doUserEditContent( $newContent, $user, $reason, $flags ); |
| 210 | |
| 211 | return true; |
| 212 | } |
| 213 | |
| 214 | /** |
| 215 | * Get the final destination of a redirect |
| 216 | * |
| 217 | * @param LinkTarget $title |
| 218 | * |
| 219 | * @return Title|false The final Title after following all redirects, or false if |
| 220 | * the page is not a redirect or the redirect loops. |
| 221 | */ |
| 222 | public static function getFinalDestination( $title ) { |
| 223 | $dbw = MediaWikiServices::getInstance()->getConnectionProvider()->getPrimaryDatabase(); |
| 224 | |
| 225 | // Circular redirect check |
| 226 | $seenTitles = []; |
| 227 | $dest = false; |
| 228 | |
| 229 | while ( true ) { |
| 230 | $titleText = CacheKeyHelper::getKeyForPage( $title ); |
| 231 | if ( isset( $seenTitles[$titleText] ) ) { |
| 232 | wfDebug( __METHOD__, "Circular redirect detected, aborting" ); |
| 233 | |
| 234 | return false; |
| 235 | } |
| 236 | $seenTitles[$titleText] = true; |
| 237 | |
| 238 | if ( $title->isExternal() ) { |
| 239 | // If the target is interwiki, we have to break early (T42352). |
| 240 | // Otherwise it will look up a row in the local page table |
| 241 | // with the namespace/page of the interwiki target which can cause |
| 242 | // unexpected results (e.g. X -> foo:Bar -> Bar -> .. ) |
| 243 | break; |
| 244 | } |
| 245 | $row = $dbw->newSelectQueryBuilder() |
| 246 | ->select( [ 'rd_namespace', 'rd_title', 'rd_interwiki' ] ) |
| 247 | ->from( 'redirect' ) |
| 248 | ->join( 'page', null, 'page_id = rd_from' ) |
| 249 | ->where( [ 'page_namespace' => $title->getNamespace() ] ) |
| 250 | ->andWhere( [ 'page_title' => $title->getDBkey() ] ) |
| 251 | ->caller( __METHOD__ )->fetchRow(); |
| 252 | if ( !$row ) { |
| 253 | # No redirect from here, chain terminates |
| 254 | break; |
| 255 | } else { |
| 256 | $dest = $title = Title::makeTitle( |
| 257 | $row->rd_namespace, |
| 258 | $row->rd_title, |
| 259 | '', |
| 260 | $row->rd_interwiki |
| 261 | ); |
| 262 | } |
| 263 | } |
| 264 | |
| 265 | return $dest; |
| 266 | } |
| 267 | |
| 268 | /** |
| 269 | * Get a user object for doing edits, from a request-lifetime cache |
| 270 | * False will be returned if the user name specified in the |
| 271 | * 'double-redirect-fixer' message is invalid. |
| 272 | * |
| 273 | * @return User|false |
| 274 | */ |
| 275 | private function getUser() { |
| 276 | if ( !self::$user ) { |
| 277 | $username = wfMessage( 'double-redirect-fixer' )->inContentLanguage()->text(); |
| 278 | self::$user = User::newFromName( $username ); |
| 279 | # User::newFromName() can return false on a badly configured wiki. |
| 280 | if ( self::$user && !self::$user->isRegistered() ) { |
| 281 | self::$user->addToDatabase(); |
| 282 | } |
| 283 | } |
| 284 | |
| 285 | return self::$user; |
| 286 | } |
| 287 | } |
| 288 | |
| 289 | /** @deprecated class alias since 1.44 */ |
| 290 | class_alias( DoubleRedirectJob::class, 'DoubleRedirectJob' ); |