MediaWiki REL1_33
UserPasswordPolicyTest.php
Go to the documentation of this file.
1<?php
28
29 protected $tablesUsed = [ 'user', 'user_groups' ];
30
31 protected $policies = [
32 'checkuser' => [
33 'MinimalPasswordLength' => [ 'value' => 10, 'forceChange' => true ],
34 'MinimumPasswordLengthToLogin' => 6,
35 'PasswordCannotMatchUsername' => true,
36 ],
37 'sysop' => [
38 'MinimalPasswordLength' => [ 'value' => 8, 'suggestChangeOnLogin' => true ],
39 'MinimumPasswordLengthToLogin' => 1,
40 'PasswordCannotMatchUsername' => true,
41 ],
42 'bureaucrat' => [
43 'MinimalPasswordLength' => [
44 'value' => 6,
45 'suggestChangeOnLogin' => false,
46 'forceChange' => true,
47 ],
48 'PasswordCannotMatchUsername' => true,
49 ],
50 'default' => [
51 'MinimalPasswordLength' => 4,
52 'MinimumPasswordLengthToLogin' => 1,
53 'PasswordCannotMatchBlacklist' => true,
54 'MaximalPasswordLength' => 4096,
55 // test null handling
56 'PasswordCannotMatchUsername' => null,
57 ],
58 ];
59
60 protected $checks = [
61 'MinimalPasswordLength' => 'PasswordPolicyChecks::checkMinimalPasswordLength',
62 'MinimumPasswordLengthToLogin' => 'PasswordPolicyChecks::checkMinimumPasswordLengthToLogin',
63 'PasswordCannotMatchUsername' => 'PasswordPolicyChecks::checkPasswordCannotMatchUsername',
64 'PasswordCannotMatchBlacklist' => 'PasswordPolicyChecks::checkPasswordCannotMatchBlacklist',
65 'MaximalPasswordLength' => 'PasswordPolicyChecks::checkMaximalPasswordLength',
66 ];
67
68 private function getUserPasswordPolicy() {
69 return new UserPasswordPolicy( $this->policies, $this->checks );
70 }
71
72 public function testGetPoliciesForUser() {
73 $upp = $this->getUserPasswordPolicy();
74
75 $user = $this->getTestUser( [ 'sysop' ] )->getUser();
76 $this->assertArrayEquals(
77 [
78 'MinimalPasswordLength' => [ 'value' => 8, 'suggestChangeOnLogin' => true ],
79 'MinimumPasswordLengthToLogin' => 1,
80 'PasswordCannotMatchUsername' => true,
81 'PasswordCannotMatchBlacklist' => true,
82 'MaximalPasswordLength' => 4096,
83 ],
84 $upp->getPoliciesForUser( $user )
85 );
86
87 $user = $this->getTestUser( [ 'sysop', 'checkuser' ] )->getUser();
88 $this->assertArrayEquals(
89 [
90 'MinimalPasswordLength' => [
91 'value' => 10,
92 'forceChange' => true,
93 'suggestChangeOnLogin' => true
94 ],
95 'MinimumPasswordLengthToLogin' => 6,
96 'PasswordCannotMatchUsername' => true,
97 'PasswordCannotMatchBlacklist' => true,
98 'MaximalPasswordLength' => 4096,
99 ],
100 $upp->getPoliciesForUser( $user )
101 );
102 }
103
104 public function testGetPoliciesForGroups() {
106 $this->policies,
107 [ 'user', 'checkuser', 'sysop' ],
108 $this->policies['default']
109 );
110
111 $this->assertArrayEquals(
112 [
113 'MinimalPasswordLength' => [
114 'value' => 10,
115 'forceChange' => true,
116 'suggestChangeOnLogin' => true
117 ],
118 'MinimumPasswordLengthToLogin' => 6,
119 'PasswordCannotMatchUsername' => true,
120 'PasswordCannotMatchBlacklist' => true,
121 'MaximalPasswordLength' => 4096,
122 ],
123 $effective
124 );
125 }
126
130 public function testCheckUserPassword( $groups, $password, StatusValue $expectedStatus ) {
131 $upp = $this->getUserPasswordPolicy();
132 $user = $this->getTestUser( $groups )->getUser();
133
134 $status = $upp->checkUserPassword( $user, $password );
135 $this->assertSame( $expectedStatus->isGood(), $status->isGood(), 'password valid' );
136 $this->assertSame( $expectedStatus->isOK(), $status->isOK(), 'can login' );
137 $this->assertSame( $expectedStatus->getValue(), $status->getValue(), 'flags' );
138 }
139
140 public function provideCheckUserPassword() {
141 $success = Status::newGood( [] );
142 $warning = Status::newGood( [] );
143 $forceChange = Status::newGood( [ 'forceChange' => true ] );
144 $suggestChangeOnLogin = Status::newGood( [ 'suggestChangeOnLogin' => true ] );
145 $fatal = Status::newGood( [] );
146
147 // the message does not matter, we only test for state and value
148 $warning->warning( 'invalid-password' );
149 $forceChange->warning( 'invalid-password' );
150 $suggestChangeOnLogin->warning( 'invalid-password' );
151 $warning->warning( 'invalid-password' );
152 $fatal->fatal( 'invalid-password' );
153
154 return [
155 'No groups, default policy, password too short to login' => [
156 [],
157 '',
158 $fatal,
159 ],
160 'Default policy, short password' => [
161 [ 'user' ],
162 'aaa',
163 $warning,
164 ],
165 'Sysop with good password' => [
166 [ 'sysop' ],
167 'abcdabcdabcd',
168 $success,
169 ],
170 'Sysop with short password and suggestChangeOnLogin set to true' => [
171 [ 'sysop' ],
172 'abcd',
173 $suggestChangeOnLogin,
174 ],
175 'Checkuser with short password' => [
176 [ 'checkuser' ],
177 'abcdabcd',
178 $forceChange,
179 ],
180 'Bureaucrat bad password with forceChange true, suggestChangeOnLogin false' => [
181 [ 'bureaucrat' ],
182 'short',
183 $forceChange,
184 ],
185 'Checkuser with too short password to login' => [
186 [ 'sysop', 'checkuser' ],
187 'abcd',
188 $fatal,
189 ],
190 ];
191 }
192
194 $upp = $this->getUserPasswordPolicy();
195 $user = User::newFromName( 'Useruser' );
196 $user->addToDatabase();
197
198 $status = $upp->checkUserPassword( $user, 'Passpass' );
199 $this->assertFalse( $status->isGood(), 'password invalid' );
200 $this->assertTrue( $status->isOK(), 'can login' );
201 }
202
206 public function testMaxOfPolicies( $p1, $p2, $max ) {
207 $this->assertArrayEquals(
208 $max,
210 );
211 }
212
213 public function provideMaxOfPolicies() {
214 return [
215 'Basic max in p1' => [
216 [ 'MinimalPasswordLength' => 8 ], // p1
217 [ 'MinimalPasswordLength' => 2 ], // p2
218 [ 'MinimalPasswordLength' => 8 ], // max
219 ],
220 'Basic max in p2' => [
221 [ 'MinimalPasswordLength' => 2 ], // p1
222 [ 'MinimalPasswordLength' => 8 ], // p2
223 [ 'MinimalPasswordLength' => 8 ], // max
224 ],
225 'Missing items in p1' => [
226 [
227 'MinimalPasswordLength' => 8,
228 ], // p1
229 [
230 'MinimalPasswordLength' => 2,
231 'PasswordCannotMatchUsername' => 1,
232 ], // p2
233 [
234 'MinimalPasswordLength' => 8,
235 'PasswordCannotMatchUsername' => 1,
236 ], // max
237 ],
238 'Missing items in p2' => [
239 [
240 'MinimalPasswordLength' => 8,
241 'PasswordCannotMatchUsername' => 1,
242 ], // p1
243 [
244 'MinimalPasswordLength' => 2,
245 ], // p2
246 [
247 'MinimalPasswordLength' => 8,
248 'PasswordCannotMatchUsername' => 1,
249 ], // max
250 ],
251 'complex value in p1' => [
252 [
253 'MinimalPasswordLength' => [
254 'value' => 8,
255 'foo' => 1,
256 ],
257 ], // p1
258 [
259 'MinimalPasswordLength' => 2,
260 ], // p2
261 [
262 'MinimalPasswordLength' => [
263 'value' => 8,
264 'foo' => 1,
265 ],
266 ], // max
267 ],
268 'complex value in p2' => [
269 [
270 'MinimalPasswordLength' => 8,
271 ], // p1
272 [
273 'MinimalPasswordLength' => [
274 'value' => 2,
275 'foo' => 1,
276 ],
277 ], // p2
278 [
279 'MinimalPasswordLength' => [
280 'value' => 8,
281 'foo' => 1,
282 ],
283 ], // max
284 ],
285 'complex value in both p1 and p2' => [
286 [
287 'MinimalPasswordLength' => [
288 'value' => 8,
289 'foo' => 1,
290 'baz' => false,
291 ],
292 ], // p1
293 [
294 'MinimalPasswordLength' => [
295 'value' => 2,
296 'bar' => 2,
297 'baz' => true,
298 ],
299 ], // p2
300 [
301 'MinimalPasswordLength' => [
302 'value' => 8,
303 'foo' => 1,
304 'bar' => 2,
305 'baz' => true,
306 ],
307 ], // max
308 ],
309 'complex value in both p1 and p2 #2' => [
310 [
311 'MinimalPasswordLength' => [
312 'value' => 8,
313 'foo' => 1,
314 'baz' => false,
315 ],
316 ], // p1
317 [
318 'MinimalPasswordLength' => [
319 'value' => 2,
320 'bar' => true
321 ],
322 ], // p2
323 [
324 'MinimalPasswordLength' => [
325 'value' => 8,
326 'foo' => 1,
327 'bar' => true,
328 'baz' => false,
329 ],
330 ], // max
331 ],
332 ];
333 }
334
335}
static getTestUser( $groups=[])
Convenience method for getting an immutable test user.
assertArrayEquals(array $expected, array $actual, $ordered=false, $named=false)
Assert that two arrays are equal.
Generic operation result class Has warning/error list, boolean status and arbitrary value.
isOK()
Returns whether the operation completed.
isGood()
Returns whether the operation completed and didn't have any error or warnings.
Database UserPasswordPolicy.
testMaxOfPolicies( $p1, $p2, $max)
provideMaxOfPolicies
testCheckUserPassword( $groups, $password, StatusValue $expectedStatus)
provideCheckUserPassword
Check if a user's password complies with any password policies that apply to that user,...
static getPoliciesForGroups(array $policies, array $userGroups, array $defaultPolicy)
Utility function to get the effective policy from a list of policies, based on a list of groups.
static maxOfPolicies(array $p1, array $p2)
Utility function to get a policy that is the most restrictive of $p1 and $p2.
static newFromName( $name, $validate='valid')
Static factory method for creation from username.
Definition User.php:585
Status::newGood()` to allow deletion, and then `return false` from the hook function. Ensure you consume the 'ChangeTagAfterDelete' hook to carry out custom deletion actions. $tag:name of the tag $user:user initiating the action & $status:Status object. See above. 'ChangeTagsListActive':Allows you to nominate which of the tags your extension uses are in active use. & $tags:list of all active tags. Append to this array. 'ChangeTagsAfterUpdateTags':Called after tags have been updated with the ChangeTags::updateTags function. Params:$addedTags:tags effectively added in the update $removedTags:tags effectively removed in the update $prevTags:tags that were present prior to the update $rc_id:recentchanges table id $rev_id:revision table id $log_id:logging table id $params:tag params $rc:RecentChange being tagged when the tagging accompanies the action, or null $user:User who performed the tagging when the tagging is subsequent to the action, or null 'ChangeTagsAllowedAdd':Called when checking if a user can add tags to a change. & $allowedTags:List of all the tags the user is allowed to add. Any tags the user wants to add( $addTags) that are not in this array will cause it to fail. You may add or remove tags to this array as required. $addTags:List of tags user intends to add. $user:User who is adding the tags. 'ChangeUserGroups':Called before user groups are changed. $performer:The User who will perform the change $user:The User whose groups will be changed & $add:The groups that will be added & $remove:The groups that will be removed 'Collation::factory':Called if $wgCategoryCollation is an unknown collation. $collationName:Name of the collation in question & $collationObject:Null. Replace with a subclass of the Collation class that implements the collation given in $collationName. 'ConfirmEmailComplete':Called after a user 's email has been confirmed successfully. $user:user(object) whose email is being confirmed 'ContentAlterParserOutput':Modify parser output for a given content object. Called by Content::getParserOutput after parsing has finished. Can be used for changes that depend on the result of the parsing but have to be done before LinksUpdate is called(such as adding tracking categories based on the rendered HTML). $content:The Content to render $title:Title of the page, as context $parserOutput:ParserOutput to manipulate 'ContentGetParserOutput':Customize parser output for a given content object, called by AbstractContent::getParserOutput. May be used to override the normal model-specific rendering of page content. $content:The Content to render $title:Title of the page, as context $revId:The revision ID, as context $options:ParserOptions for rendering. To avoid confusing the parser cache, the output can only depend on parameters provided to this hook function, not on global state. $generateHtml:boolean, indicating whether full HTML should be generated. If false, generation of HTML may be skipped, but other information should still be present in the ParserOutput object. & $output:ParserOutput, to manipulate or replace 'ContentHandlerDefaultModelFor':Called when the default content model is determined for a given title. May be used to assign a different model for that title. $title:the Title in question & $model:the model name. Use with CONTENT_MODEL_XXX constants. 'ContentHandlerForModelID':Called when a ContentHandler is requested for a given content model name, but no entry for that model exists in $wgContentHandlers. Note:if your extension implements additional models via this hook, please use GetContentModels hook to make them known to core. $modeName:the requested content model name & $handler:set this to a ContentHandler object, if desired. 'ContentModelCanBeUsedOn':Called to determine whether that content model can be used on a given page. This is especially useful to prevent some content models to be used in some special location. $contentModel:ID of the content model in question $title:the Title in question. & $ok:Output parameter, whether it is OK to use $contentModel on $title. Handler functions that modify $ok should generally return false to prevent further hooks from further modifying $ok. 'ContribsPager::getQueryInfo':Before the contributions query is about to run & $pager:Pager object for contributions & $queryInfo:The query for the contribs Pager 'ContribsPager::reallyDoQuery':Called before really executing the query for My Contributions & $data:an array of results of all contribs queries $pager:The ContribsPager object hooked into $offset:Index offset, inclusive $limit:Exact query limit $descending:Query direction, false for ascending, true for descending 'ContributionsLineEnding':Called before a contributions HTML line is finished $page:SpecialPage object for contributions & $ret:the HTML line $row:the DB row for this line & $classes:the classes to add to the surrounding< li > & $attribs:associative array of other HTML attributes for the< li > element. Currently only data attributes reserved to MediaWiki are allowed(see Sanitizer::isReservedDataAttribute). 'ContributionsToolLinks':Change tool links above Special:Contributions $id:User identifier $title:User page title & $tools:Array of tool links $specialPage:SpecialPage instance for context and services. Can be either SpecialContributions or DeletedContributionsPage. Extensions should type hint against a generic SpecialPage though. 'ConvertContent':Called by AbstractContent::convert when a conversion to another content model is requested. Handler functions that modify $result should generally return false to disable further attempts at conversion. $content:The Content object to be converted. $toModel:The ID of the content model to convert to. $lossy:boolean indicating whether lossy conversion is allowed. & $result:Output parameter, in case the handler function wants to provide a converted Content object. Note that $result->getContentModel() must return $toModel. 'ContentSecurityPolicyDefaultSource':Modify the allowed CSP load sources. This affects all directives except for the script directive. If you want to add a script source, see ContentSecurityPolicyScriptSource hook. & $defaultSrc:Array of Content-Security-Policy allowed sources $policyConfig:Current configuration for the Content-Security-Policy header $mode:ContentSecurityPolicy::REPORT_ONLY_MODE or ContentSecurityPolicy::FULL_MODE depending on type of header 'ContentSecurityPolicyDirectives':Modify the content security policy directives. Use this only if ContentSecurityPolicyDefaultSource and ContentSecurityPolicyScriptSource do not meet your needs. & $directives:Array of CSP directives $policyConfig:Current configuration for the CSP header $mode:ContentSecurityPolicy::REPORT_ONLY_MODE or ContentSecurityPolicy::FULL_MODE depending on type of header 'ContentSecurityPolicyScriptSource':Modify the allowed CSP script sources. Note that you also have to use ContentSecurityPolicyDefaultSource if you want non-script sources to be loaded from whatever you add. & $scriptSrc:Array of CSP directives $policyConfig:Current configuration for the CSP header $mode:ContentSecurityPolicy::REPORT_ONLY_MODE or ContentSecurityPolicy::FULL_MODE depending on type of header 'CustomEditor':When invoking the page editor Return true to allow the normal editor to be used, or false if implementing a custom editor, e.g. for a special namespace, etc. $article:Article being edited $user:User performing the edit 'DatabaseOraclePostInit':Called after initialising an Oracle database $db:the DatabaseOracle object 'DeletedContribsPager::reallyDoQuery':Called before really executing the query for Special:DeletedContributions Similar to ContribsPager::reallyDoQuery & $data:an array of results of all contribs queries $pager:The DeletedContribsPager object hooked into $offset:Index offset, inclusive $limit:Exact query limit $descending:Query direction, false for ascending, true for descending 'DeletedContributionsLineEnding':Called before a DeletedContributions HTML line is finished. Similar to ContributionsLineEnding $page:SpecialPage object for DeletedContributions & $ret:the HTML line $row:the DB row for this line & $classes:the classes to add to the surrounding< li > & $attribs:associative array of other HTML attributes for the< li > element. Currently only data attributes reserved to MediaWiki are allowed(see Sanitizer::isReservedDataAttribute). 'DeleteUnknownPreferences':Called by the cleanupPreferences.php maintenance script to build a WHERE clause with which to delete preferences that are not known about. This hook is used by extensions that have dynamically-named preferences that should not be deleted in the usual cleanup process. For example, the Gadgets extension creates preferences prefixed with 'gadget-', and so anything with that prefix is excluded from the deletion. &where:An array that will be passed as the $cond parameter to IDatabase::select() to determine what will be deleted from the user_properties table. $db:The IDatabase object, useful for accessing $db->buildLike() etc. 'DifferenceEngineAfterLoadNewText':called in DifferenceEngine::loadNewText() after the new revision 's content has been loaded into the class member variable $differenceEngine->mNewContent but before returning true from this function. $differenceEngine:DifferenceEngine object 'DifferenceEngineLoadTextAfterNewContentIsLoaded':called in DifferenceEngine::loadText() after the new revision 's content has been loaded into the class member variable $differenceEngine->mNewContent but before checking if the variable 's value is null. This hook can be used to inject content into said class member variable. $differenceEngine:DifferenceEngine object 'DifferenceEngineMarkPatrolledLink':Allows extensions to change the "mark as patrolled" link which is shown both on the diff header as well as on the bottom of a page, usually wrapped in a span element which has class="patrollink". $differenceEngine:DifferenceEngine object & $markAsPatrolledLink:The "mark as patrolled" link HTML(string) $rcid:Recent change ID(rc_id) for this change(int) 'DifferenceEngineMarkPatrolledRCID':Allows extensions to possibly change the rcid parameter. For example the rcid might be set to zero due to the user being the same as the performer of the change but an extension might still want to show it under certain conditions. & $rcid:rc_id(int) of the change or 0 $differenceEngine:DifferenceEngine object $change:RecentChange object $user:User object representing the current user 'DifferenceEngineNewHeader':Allows extensions to change the $newHeader variable, which contains information about the new revision, such as the revision 's author, whether the revision was marked as a minor edit or not, etc. $differenceEngine:DifferenceEngine object & $newHeader:The string containing the various #mw-diff-otitle[1-5] divs, which include things like revision author info, revision comment, RevisionDelete link and more $formattedRevisionTools:Array containing revision tools, some of which may have been injected with the DiffRevisionTools hook $nextlink:String containing the link to the next revision(if any) $status
Definition hooks.txt:1266
null means default in associative array with keys and values unescaped Should be merged with default with a value of false meaning to suppress the attribute in associative array with keys and values unescaped noclasses just before the function returns a value If you return true
Definition hooks.txt:2004
return true to allow those checks to and false if checking is done & $user
Definition hooks.txt:1510
injection txt This is an overview of how MediaWiki makes use of dependency injection The design described here grew from the discussion of RFC T384 The term dependency this means that anything an object needs to operate should be injected from the the object itself should only know narrow no concrete implementation of the logic it relies on The requirement to inject everything typically results in an architecture that based on two main types of and essentially stateless service objects that use other service objects to operate on the value objects As of the beginning MediaWiki is only starting to use the DI approach Much of the code still relies on global state or direct resulting in a highly cyclical dependency which acts as the top level factory for services in MediaWiki which can be used to gain access to default instances of various services MediaWikiServices however also allows new services to be defined and default services to be redefined Services are defined or redefined by providing a callback the instantiator that will return a new instance of the service When it will create an instance of MediaWikiServices and populate it with the services defined in the files listed by thereby bootstrapping the DI framework Per $wgServiceWiringFiles lists includes ServiceWiring php
Definition injection.txt:37