MovePage.php

Go to the documentation of this file.

<?php
 
use MediaWiki\Config\ServiceOptions;
use MediaWiki\Content\IContentHandlerFactory;
use MediaWiki\EditPage\SpamChecker;
use MediaWiki\HookContainer\HookContainer;
use MediaWiki\HookContainer\HookRunner;
use MediaWiki\MediaWikiServices;
use MediaWiki\Permissions\PermissionManager;
use MediaWiki\Revision\MutableRevisionRecord;
use MediaWiki\Revision\RevisionRecord;
use MediaWiki\Revision\RevisionStore;
use MediaWiki\Revision\SlotRecord;
use Wikimedia\Rdbms\IDatabase;
use Wikimedia\Rdbms\ILoadBalancer;
 
class MovePage {
 
    protected $oldTitle;
 
    protected $newTitle;
 
    protected $options;
 
    protected $loadBalancer;
 
    protected $nsInfo;
 
    protected $watchedItems;
 
    protected $permMgr;
 
    protected $repoGroup;
 
    private $contentHandlerFactory;
 
    private $revisionStore;
 
    private $spamChecker;
 
    private $hookContainer;
 
    private $hookRunner;
 
    public const CONSTRUCTOR_OPTIONS = [
        'CategoryCollation'
    ];
 
    public function __construct(
        Title $oldTitle,
        Title $newTitle,
        ServiceOptions $options = null,
        ILoadBalancer $loadBalancer = null,
        NamespaceInfo $nsInfo = null,
        WatchedItemStoreInterface $watchedItems = null,
        PermissionManager $permMgr = null,
        RepoGroup $repoGroup = null,
        IContentHandlerFactory $contentHandlerFactory = null,
        RevisionStore $revisionStore = null,
        SpamChecker $spamChecker = null,
        HookContainer $hookContainer = null
    ) {
        $this->oldTitle = $oldTitle;
        $this->newTitle = $newTitle;
 
        $services = MediaWikiServices::getInstance();
        $this->options = $options ??
            new ServiceOptions(
                self::CONSTRUCTOR_OPTIONS,
                $services->getMainConfig()
            );
        $this->loadBalancer = $loadBalancer ?? $services->getDBLoadBalancer();
        $this->nsInfo = $nsInfo ?? $services->getNamespaceInfo();
        $this->watchedItems = $watchedItems ?? $services->getWatchedItemStore();
        $this->permMgr = $permMgr ?? $services->getPermissionManager();
        $this->repoGroup = $repoGroup ?? $services->getRepoGroup();
        $this->contentHandlerFactory =
            $contentHandlerFactory ?? $services->getContentHandlerFactory();
 
        $this->revisionStore = $revisionStore ?? $services->getRevisionStore();
        $this->spamChecker = $spamChecker ?? $services->getSpamChecker();
        $this->hookContainer = $hookContainer ?? $services->getHookContainer();
        $this->hookRunner = new HookRunner( $this->hookContainer );
    }
 
    public function checkPermissions( User $user, $reason ) {
        $status = new Status();
 
        $errors = wfMergeErrorArrays(
            $this->permMgr->getPermissionErrors( 'move', $user, $this->oldTitle ),
            $this->permMgr->getPermissionErrors( 'edit', $user, $this->oldTitle ),
            $this->permMgr->getPermissionErrors( 'move-target', $user, $this->newTitle ),
            $this->permMgr->getPermissionErrors( 'edit', $user, $this->newTitle )
        );
 
        // Convert into a Status object
        if ( $errors ) {
            foreach ( $errors as $error ) {
                $status->fatal( ...$error );
            }
        }
 
        if ( $reason !== null && $this->spamChecker->checkSummary( $reason ) !== false ) {
            // This is kind of lame, won't display nice
            $status->fatal( 'spamprotectiontext' );
        }
 
        $tp = $this->newTitle->getTitleProtection();
        if ( $tp !== false && !$this->permMgr->userHasRight( $user, $tp['permission'] ) ) {
            $status->fatal( 'cantmove-titleprotected' );
        }
 
        $this->hookRunner->onMovePageCheckPermissions(
            $this->oldTitle, $this->newTitle, $user, $reason, $status );
 
        return $status;
    }
 
    public function isValidMove() {
        $status = new Status();
 
        if ( $this->oldTitle->equals( $this->newTitle ) ) {
            $status->fatal( 'selfmove' );
        } elseif ( $this->newTitle->getArticleID( Title::READ_LATEST /* T272386 */ )
            && !$this->isValidMoveTarget()
        ) {
            // The move is allowed only if (1) the target doesn't exist, or (2) the target is a
            // redirect to the source, and has no history (so we can undo bad moves right after
            // they're done).
            $status->fatal( 'articleexists', $this->newTitle->getPrefixedText() );
        }
 
        // @todo If the old title is invalid, maybe we should check if it somehow exists in the
        // database and allow moving it to a valid name? Why prohibit the move from an empty name
        // without checking in the database?
        if ( $this->oldTitle->getDBkey() == '' ) {
            $status->fatal( 'badarticleerror' );
        } elseif ( $this->oldTitle->isExternal() ) {
            $status->fatal( 'immobile-source-namespace-iw' );
        } elseif ( !$this->oldTitle->isMovable() ) {
            $nsText = $this->oldTitle->getNsText();
            if ( $nsText === '' ) {
                $nsText = wfMessage( 'blanknamespace' )->text();
            }
            $status->fatal( 'immobile-source-namespace', $nsText );
        } elseif ( !$this->oldTitle->exists() ) {
            $status->fatal( 'movepage-source-doesnt-exist' );
        }
 
        if ( $this->newTitle->isExternal() ) {
            $status->fatal( 'immobile-target-namespace-iw' );
        } elseif ( !$this->newTitle->isMovable() ) {
            $nsText = $this->newTitle->getNsText();
            if ( $nsText === '' ) {
                $nsText = wfMessage( 'blanknamespace' )->text();
            }
            $status->fatal( 'immobile-target-namespace', $nsText );
        }
        if ( !$this->newTitle->isValid() ) {
            $status->fatal( 'movepage-invalid-target-title' );
        }
 
        // Content model checks
        if ( !$this->contentHandlerFactory
            ->getContentHandler( $this->oldTitle->getContentModel() )
            ->canBeUsedOn( $this->newTitle )
        ) {
            $status->fatal(
                'content-not-allowed-here',
                ContentHandler::getLocalizedName( $this->oldTitle->getContentModel() ),
                $this->newTitle->getPrefixedText(),
                SlotRecord::MAIN
            );
        }
 
        // Image-specific checks
        if ( $this->oldTitle->inNamespace( NS_FILE ) ) {
            $status->merge( $this->isValidFileMove() );
        }
 
        if ( $this->newTitle->inNamespace( NS_FILE ) && !$this->oldTitle->inNamespace( NS_FILE ) ) {
            $status->fatal( 'nonfile-cannot-move-to-file' );
        }
 
        // Hook for extensions to say a title can't be moved for technical reasons
        $this->hookRunner->onMovePageIsValidMove( $this->oldTitle, $this->newTitle, $status );
 
        return $status;
    }
 
    protected function isValidFileMove() {
        $status = new Status();
 
        if ( !$this->newTitle->inNamespace( NS_FILE ) ) {
            $status->fatal( 'imagenocrossnamespace' );
            // No need for further errors about the target filename being wrong
            return $status;
        }
 
        $file = $this->repoGroup->getLocalRepo()->newFile( $this->oldTitle );
        $file->load( File::READ_LATEST );
        if ( $file->exists() ) {
            if ( $this->newTitle->getText() != wfStripIllegalFilenameChars( $this->newTitle->getText() ) ) {
                $status->fatal( 'imageinvalidfilename' );
            }
            if ( !File::checkExtensionCompatibility( $file, $this->newTitle->getDBkey() ) ) {
                $status->fatal( 'imagetypemismatch' );
            }
        }
 
        return $status;
    }
 
    protected function isValidMoveTarget() {
        # Is it an existing file?
        if ( $this->newTitle->inNamespace( NS_FILE ) ) {
            $file = $this->repoGroup->getLocalRepo()->newFile( $this->newTitle );
            $file->load( File::READ_LATEST );
            if ( $file->exists() ) {
                wfDebug( __METHOD__ . ": file exists" );
                return false;
            }
        }
        # Is it a redirect with no history?
        if ( !$this->newTitle->isSingleRevRedirect() ) {
            wfDebug( __METHOD__ . ": not a one-rev redirect" );
            return false;
        }
        # Get the article text
        $rev = $this->revisionStore->getRevisionByTitle(
            $this->newTitle,
            0,
            RevisionStore::READ_LATEST
        );
        if ( !is_object( $rev ) ) {
            return false;
        }
        $content = $rev->getContent( SlotRecord::MAIN );
        # Does the redirect point to the source?
        # Or is it a broken self-redirect, usually caused by namespace collisions?
        $redirTitle = $content ? $content->getRedirectTarget() : null;
 
        if ( $redirTitle ) {
            if ( $redirTitle->getPrefixedDBkey() !== $this->oldTitle->getPrefixedDBkey() &&
                $redirTitle->getPrefixedDBkey() !== $this->newTitle->getPrefixedDBkey() ) {
                wfDebug( __METHOD__ . ": redirect points to other page" );
                return false;
            } else {
                return true;
            }
        } else {
            # Fail safe (not a redirect after all. strange.)
            wfDebug( __METHOD__ . ": failsafe: database says " . $this->newTitle->getPrefixedDBkey() .
                " is a redirect, but it doesn't contain a valid redirect." );
            return false;
        }
    }
 
    public function move(
        User $user, $reason = null, $createRedirect = true, array $changeTags = []
    ) {
        $status = $this->isValidMove();
        if ( !$status->isOK() ) {
            return $status;
        }
 
        return $this->moveUnsafe( $user, $reason, $createRedirect, $changeTags );
    }
 
    public function moveIfAllowed(
        User $user, $reason = null, $createRedirect = true, array $changeTags = []
    ) {
        $status = $this->isValidMove();
        $status->merge( $this->checkPermissions( $user, $reason ) );
        if ( $changeTags ) {
            $status->merge( ChangeTags::canAddTagsAccompanyingChange( $changeTags, $user ) );
        }
 
        if ( !$status->isOK() ) {
            // Auto-block user's IP if the account was "hard" blocked
            $user->spreadAnyEditBlock();
            return $status;
        }
 
        // Check suppressredirect permission
        if ( !$this->permMgr->userHasRight( $user, 'suppressredirect' ) ) {
            $createRedirect = true;
        }
 
        return $this->moveUnsafe( $user, $reason, $createRedirect, $changeTags );
    }
 
    public function moveSubpages(
        User $user, $reason = null, $createRedirect = true, array $changeTags = []
    ) {
        return $this->moveSubpagesInternal( false, $user, $reason, $createRedirect, $changeTags );
    }
 
    public function moveSubpagesIfAllowed(
        User $user, $reason = null, $createRedirect = true, array $changeTags = []
    ) {
        return $this->moveSubpagesInternal( true, $user, $reason, $createRedirect, $changeTags );
    }
 
    private function moveSubpagesInternal(
        $checkPermissions, User $user, $reason, $createRedirect, array $changeTags
    ) {
        global $wgMaximumMovedPages;
 
        if ( $checkPermissions ) {
            if ( !$this->permMgr->userCan(
                'move-subpages', $user, $this->oldTitle )
            ) {
                return Status::newFatal( 'cant-move-subpages' );
            }
        }
 
        // Do the source and target namespaces support subpages?
        if ( !$this->nsInfo->hasSubpages( $this->oldTitle->getNamespace() ) ) {
            return Status::newFatal( 'namespace-nosubpages',
                $this->nsInfo->getCanonicalName( $this->oldTitle->getNamespace() ) );
        }
        if ( !$this->nsInfo->hasSubpages( $this->newTitle->getNamespace() ) ) {
            return Status::newFatal( 'namespace-nosubpages',
                $this->nsInfo->getCanonicalName( $this->newTitle->getNamespace() ) );
        }
 
        // Return a status for the overall result. Its value will be an array with per-title
        // status for each subpage. Merge any errors from the per-title statuses into the
        // top-level status without resetting the overall result.
        $topStatus = Status::newGood();
        $perTitleStatus = [];
        $subpages = $this->oldTitle->getSubpages( $wgMaximumMovedPages + 1 );
        $count = 0;
        foreach ( $subpages as $oldSubpage ) {
            $count++;
            if ( $count > $wgMaximumMovedPages ) {
                $status = Status::newFatal( 'movepage-max-pages', $wgMaximumMovedPages );
                $perTitleStatus[$oldSubpage->getPrefixedText()] = $status;
                $topStatus->merge( $status );
                $topStatus->setOK( true );
                break;
            }
 
            // We don't know whether this function was called before or after moving the root page,
            // so check both titles
            if ( $oldSubpage->getArticleID() == $this->oldTitle->getArticleID() ||
                $oldSubpage->getArticleID() == $this->newTitle->getArticleID()
            ) {
                // When moving a page to a subpage of itself, don't move it twice
                continue;
            }
            $newPageName = preg_replace(
                    '#^' . preg_quote( $this->oldTitle->getDBkey(), '#' ) . '#',
                    StringUtils::escapeRegexReplacement( $this->newTitle->getDBkey() ), # T23234
                    $oldSubpage->getDBkey() );
            if ( $oldSubpage->isTalkPage() ) {
                $newNs = $this->newTitle->getTalkPage()->getNamespace();
            } else {
                $newNs = $this->newTitle->getSubjectPage()->getNamespace();
            }
            // T16385: we need makeTitleSafe because the new page names may be longer than 255
            // characters.
            $newSubpage = Title::makeTitleSafe( $newNs, $newPageName );
 
            $mp = new MovePage( $oldSubpage, $newSubpage );
            $method = $checkPermissions ? 'moveIfAllowed' : 'move';
            $status = $mp->$method( $user, $reason, $createRedirect, $changeTags );
            if ( $status->isOK() ) {
                $status->setResult( true, $newSubpage->getPrefixedText() );
            }
            $perTitleStatus[$oldSubpage->getPrefixedText()] = $status;
            $topStatus->merge( $status );
            $topStatus->setOK( true );
        }
 
        $topStatus->value = $perTitleStatus;
        return $topStatus;
    }
 
    private function moveUnsafe( User $user, $reason, $createRedirect, array $changeTags ) {
        $status = Status::newGood();
        $this->hookRunner->onTitleMove( $this->oldTitle, $this->newTitle, $user, $reason, $status );
        if ( !$status->isOK() ) {
            // Move was aborted by the hook
            return $status;
        }
 
        $dbw = $this->loadBalancer->getConnection( DB_MASTER );
        $dbw->startAtomic( __METHOD__, IDatabase::ATOMIC_CANCELABLE );
 
        $this->hookRunner->onTitleMoveStarting( $this->oldTitle, $this->newTitle, $user );
 
        $pageid = $this->oldTitle->getArticleID( Title::READ_LATEST );
        $protected = $this->oldTitle->isProtected();
 
        // Do the actual move; if this fails, it will throw an MWException(!)
        $nullRevision = $this->moveToInternal( $user, $this->newTitle, $reason, $createRedirect,
            $changeTags );
 
        // Refresh the sortkey for this row.  Be careful to avoid resetting
        // cl_timestamp, which may disturb time-based lists on some sites.
        // @todo This block should be killed, it's duplicating code
        // from LinksUpdate::getCategoryInsertions() and friends.
        $prefixes = $dbw->select(
            'categorylinks',
            [ 'cl_sortkey_prefix', 'cl_to' ],
            [ 'cl_from' => $pageid ],
            __METHOD__
        );
        $type = $this->nsInfo->getCategoryLinkType( $this->newTitle->getNamespace() );
        foreach ( $prefixes as $prefixRow ) {
            $prefix = $prefixRow->cl_sortkey_prefix;
            $catTo = $prefixRow->cl_to;
            $dbw->update( 'categorylinks',
                [
                    'cl_sortkey' => Collation::singleton()->getSortKey(
                            $this->newTitle->getCategorySortkey( $prefix ) ),
                    'cl_collation' => $this->options->get( 'CategoryCollation' ),
                    'cl_type' => $type,
                    'cl_timestamp=cl_timestamp' ],
                [
                    'cl_from' => $pageid,
                    'cl_to' => $catTo ],
                __METHOD__
            );
        }
 
        $redirid = $this->oldTitle->getArticleID();
 
        if ( $protected ) {
            # Protect the redirect title as the title used to be...
            $res = $dbw->select(
                'page_restrictions',
                [ 'pr_type', 'pr_level', 'pr_cascade', 'pr_user', 'pr_expiry' ],
                [ 'pr_page' => $pageid ],
                __METHOD__,
                'FOR UPDATE'
            );
            $rowsInsert = [];
            foreach ( $res as $row ) {
                $rowsInsert[] = [
                    'pr_page' => $redirid,
                    'pr_type' => $row->pr_type,
                    'pr_level' => $row->pr_level,
                    'pr_cascade' => $row->pr_cascade,
                    'pr_user' => $row->pr_user,
                    'pr_expiry' => $row->pr_expiry
                ];
            }
            $dbw->insert( 'page_restrictions', $rowsInsert, __METHOD__, [ 'IGNORE' ] );
 
            // Build comment for log
            $comment = wfMessage(
                'prot_1movedto2',
                $this->oldTitle->getPrefixedText(),
                $this->newTitle->getPrefixedText()
            )->inContentLanguage()->text();
            if ( $reason ) {
                $comment .= wfMessage( 'colon-separator' )->inContentLanguage()->text() . $reason;
            }
 
            // reread inserted pr_ids for log relation
            $insertedPrIds = $dbw->select(
                'page_restrictions',
                'pr_id',
                [ 'pr_page' => $redirid ],
                __METHOD__
            );
            $logRelationsValues = [];
            foreach ( $insertedPrIds as $prid ) {
                $logRelationsValues[] = $prid->pr_id;
            }
 
            // Update the protection log
            $logEntry = new ManualLogEntry( 'protect', 'move_prot' );
            $logEntry->setTarget( $this->newTitle );
            $logEntry->setComment( $comment );
            $logEntry->setPerformer( $user );
            $logEntry->setParameters( [
                '4::oldtitle' => $this->oldTitle->getPrefixedText(),
            ] );
            $logEntry->setRelations( [ 'pr_id' => $logRelationsValues ] );
            $logEntry->addTags( $changeTags );
            $logId = $logEntry->insert();
            $logEntry->publish( $logId );
        }
 
        // Update *_from_namespace fields as needed
        if ( $this->oldTitle->getNamespace() != $this->newTitle->getNamespace() ) {
            $dbw->update( 'pagelinks',
                [ 'pl_from_namespace' => $this->newTitle->getNamespace() ],
                [ 'pl_from' => $pageid ],
                __METHOD__
            );
            $dbw->update( 'templatelinks',
                [ 'tl_from_namespace' => $this->newTitle->getNamespace() ],
                [ 'tl_from' => $pageid ],
                __METHOD__
            );
            $dbw->update( 'imagelinks',
                [ 'il_from_namespace' => $this->newTitle->getNamespace() ],
                [ 'il_from' => $pageid ],
                __METHOD__
            );
        }
 
        # Update watchlists
        $oldtitle = $this->oldTitle->getDBkey();
        $newtitle = $this->newTitle->getDBkey();
        $oldsnamespace = $this->nsInfo->getSubject( $this->oldTitle->getNamespace() );
        $newsnamespace = $this->nsInfo->getSubject( $this->newTitle->getNamespace() );
        if ( $oldsnamespace != $newsnamespace || $oldtitle != $newtitle ) {
            $this->watchedItems->duplicateAllAssociatedEntries( $this->oldTitle, $this->newTitle );
        }
 
        // If it is a file then move it last.
        // This is done after all database changes so that file system errors cancel the transaction.
        if ( $this->oldTitle->getNamespace() == NS_FILE ) {
            $status = $this->moveFile( $this->oldTitle, $this->newTitle );
            if ( !$status->isOK() ) {
                $dbw->cancelAtomic( __METHOD__ );
                return $status;
            }
        }
 
        $this->hookRunner->onPageMoveCompleting(
            $this->oldTitle, $this->newTitle,
            $user, $pageid, $redirid, $reason, $nullRevision
        );
 
        // Deprecated since 1.35, use PageMoveCompleting
        if ( $this->hookContainer->isRegistered( 'TitleMoveCompleting' ) ) {
            // Only create the Revision object if needed
            $nullRevisionObj = new Revision( $nullRevision );
            $this->hookRunner->onTitleMoveCompleting(
                $this->oldTitle,
                $this->newTitle,
                $user,
                $pageid,
                $redirid,
                $reason,
                $nullRevisionObj
            );
        }
 
        $dbw->endAtomic( __METHOD__ );
 
        // Keep each single hook handler atomic
        DeferredUpdates::addUpdate(
            new AtomicSectionUpdate(
                $dbw,
                __METHOD__,
                function () use ( $user, $pageid, $redirid, $reason, $nullRevision ) {
                    $this->hookRunner->onPageMoveComplete(
                        $this->oldTitle,
                        $this->newTitle,
                        $user,
                        $pageid,
                        $redirid,
                        $reason,
                        $nullRevision
                    );
 
                    if ( !$this->hookContainer->isRegistered( 'TitleMoveComplete' ) ) {
                        // Don't go on to create a Revision unless its needed
                        return;
                    }
 
                    $nullRevisionObj = new Revision( $nullRevision );
                    // Deprecated since 1.35, use PageMoveComplete
                    $this->hookRunner->onTitleMoveComplete(
                        $this->oldTitle,
                        $this->newTitle,
                        $user, $pageid,
                        $redirid,
                        $reason,
                        $nullRevisionObj
                    );
                }
            )
        );
 
        return Status::newGood();
    }
 
    private function moveFile( $oldTitle, $newTitle ) {
        $file = $this->repoGroup->getLocalRepo()->newFile( $oldTitle );
        $file->load( File::READ_LATEST );
        if ( $file->exists() ) {
            $status = $file->move( $newTitle );
        } else {
            $status = Status::newGood();
        }
 
        // Clear RepoGroup process cache
        $this->repoGroup->clearCache( $oldTitle );
        $this->repoGroup->clearCache( $newTitle ); # clear false negative cache
        return $status;
    }
 
    private function moveToInternal( User $user, &$nt, $reason = '', $createRedirect = true,
        array $changeTags = []
    ) {
        if ( $nt->exists() ) {
            $moveOverRedirect = true;
            $logType = 'move_redir';
        } else {
            $moveOverRedirect = false;
            $logType = 'move';
        }
 
        if ( $moveOverRedirect ) {
            $overwriteMessage = wfMessage(
                    'delete_and_move_reason',
                    $this->oldTitle->getPrefixedText()
                )->inContentLanguage()->text();
            $newpage = WikiPage::factory( $nt );
            $errs = [];
            $status = $newpage->doDeleteArticleReal(
                $overwriteMessage,
                $user,
                /* $suppress */ false,
                /* unused */ null,
                $errs,
                /* unused */ null,
                $changeTags,
                'delete_redir'
            );
 
            if ( !$status->isGood() ) {
                throw new MWException( 'Failed to delete page-move revision: '
                    . $status->getWikiText( false, false, 'en' ) );
            }
 
            $nt->resetArticleID( false );
        }
 
        if ( $createRedirect ) {
            if ( $this->oldTitle->getNamespace() == NS_CATEGORY
                && !wfMessage( 'category-move-redirect-override' )->inContentLanguage()->isDisabled()
            ) {
                $redirectContent = new WikitextContent(
                    wfMessage( 'category-move-redirect-override' )
                        ->params( $nt->getPrefixedText() )->inContentLanguage()->plain() );
            } else {
                $redirectContent = $this->contentHandlerFactory
                    ->getContentHandler( $this->oldTitle->getContentModel() )
                    ->makeRedirectContent(
                        $nt,
                        wfMessage( 'move-redirect-text' )->inContentLanguage()->plain()
                    );
            }
 
            // NOTE: If this page's content model does not support redirects, $redirectContent will be null.
        } else {
            $redirectContent = null;
        }
 
        // T59084: log_page should be the ID of the *moved* page
        $oldid = $this->oldTitle->getArticleID();
        $logTitle = clone $this->oldTitle;
 
        $logEntry = new ManualLogEntry( 'move', $logType );
        $logEntry->setPerformer( $user );
        $logEntry->setTarget( $logTitle );
        $logEntry->setComment( $reason );
        $logEntry->setParameters( [
            '4::target' => $nt->getPrefixedText(),
            '5::noredir' => $redirectContent ? '0' : '1',
        ] );
 
        $formatter = LogFormatter::newFromEntry( $logEntry );
        $formatter->setContext( RequestContext::newExtraneousContext( $this->oldTitle ) );
        $comment = $formatter->getPlainActionText();
        if ( $reason ) {
            $comment .= wfMessage( 'colon-separator' )->inContentLanguage()->text() . $reason;
        }
 
        $dbw = $this->loadBalancer->getConnection( DB_MASTER );
 
        $oldpage = WikiPage::factory( $this->oldTitle );
        $oldcountable = $oldpage->isCountable();
 
        $newpage = WikiPage::factory( $nt );
 
        # Change the name of the target page:
        $dbw->update( 'page',
            /* SET */ [
                'page_namespace' => $nt->getNamespace(),
                'page_title' => $nt->getDBkey(),
            ],
            /* WHERE */ [ 'page_id' => $oldid ],
            __METHOD__
        );
 
        // Reset $nt before using it to create the null revision (T248789).
        // But not $this->oldTitle yet, see below (T47348).
        $nt->resetArticleID( $oldid );
 
        $commentObj = CommentStoreComment::newUnsavedComment( $comment );
        # Save a null revision in the page's history notifying of the move
        $nullRevision = $this->revisionStore->newNullRevision(
            $dbw,
            $nt,
            $commentObj,
            true,
            $user
        );
        if ( !is_object( $nullRevision ) ) {
            throw new MWException( 'Failed to create null revision while moving page ID '
                . $oldid . ' to ' . $nt->getPrefixedDBkey() );
        }
 
        $nullRevision = $this->revisionStore->insertRevisionOn( $nullRevision, $dbw );
        $logEntry->setAssociatedRevId( $nullRevision->getId() );
 
        $user->incEditCount();
 
        if ( !$redirectContent ) {
            // Clean up the old title *before* reset article id - T47348
            WikiPage::onArticleDelete( $this->oldTitle );
        }
 
        $this->oldTitle->resetArticleID( 0 ); // 0 == non existing
        $newpage->loadPageData( WikiPage::READ_LOCKING ); // T48397
 
        $newpage->updateRevisionOn( $dbw, $nullRevision );
 
        $fakeTags = [];
        $this->hookRunner->onRevisionFromEditComplete(
            $newpage, $nullRevision, $nullRevision->getParentId(), $user, $fakeTags );
 
        // Hook is hard deprecated since 1.35
        if ( $this->hookContainer->isRegistered( 'NewRevisionFromEditComplete' ) ) {
            // Only create the Revision object if needed
            $nullRevisionObj = new Revision( $nullRevision );
            $this->hookRunner->onNewRevisionFromEditComplete(
                $newpage,
                $nullRevisionObj,
                $nullRevision->getParentId(),
                $user,
                $fakeTags
            );
        }
 
        $newpage->doEditUpdates( $nullRevision, $user,
            [ 'changed' => false, 'moved' => true, 'oldcountable' => $oldcountable ] );
 
        WikiPage::onArticleCreate( $nt );
 
        # Recreate the redirect, this time in the other direction.
        if ( $redirectContent ) {
            $redirectArticle = WikiPage::factory( $this->oldTitle );
            $redirectArticle->loadFromRow( false, WikiPage::READ_LOCKING ); // T48397
            $newid = $redirectArticle->insertOn( $dbw );
            if ( $newid ) { // sanity
                $this->oldTitle->resetArticleID( $newid );
                $redirectRevisionRecord = new MutableRevisionRecord( $this->oldTitle );
                $redirectRevisionRecord->setPageId( $newid );
                $redirectRevisionRecord->setUser( $user );
                $redirectRevisionRecord->setComment( $commentObj );
                $redirectRevisionRecord->setContent( SlotRecord::MAIN, $redirectContent );
                $redirectRevisionRecord->setTimestamp( MWTimestamp::now( TS_MW ) );
 
                $inserted = $this->revisionStore->insertRevisionOn(
                    $redirectRevisionRecord,
                    $dbw
                );
                $redirectRevId = $inserted->getId();
                $redirectArticle->updateRevisionOn( $dbw, $inserted, 0 );
 
                $fakeTags = [];
                $this->hookRunner->onRevisionFromEditComplete(
                    $redirectArticle,
                    $inserted,
                    false,
                    $user,
                    $fakeTags
                );
 
                // Hook is hard deprecated since 1.35
                if ( $this->hookContainer->isRegistered( 'NewRevisionFromEditComplete' ) ) {
                    // Only create the Revision object if needed
                    $redirectRevisionObj = new Revision( $inserted );
                    $this->hookRunner->onNewRevisionFromEditComplete(
                        $redirectArticle,
                        $redirectRevisionObj,
                        false,
                        $user,
                        $fakeTags
                    );
                }
 
                $redirectArticle->doEditUpdates(
                    $inserted,
                    $user,
                    [ 'created' => true ]
                );
 
                // make a copy because of log entry below
                $redirectTags = $changeTags;
                if ( in_array( 'mw-new-redirect', ChangeTags::getSoftwareTags() ) ) {
                    $redirectTags[] = 'mw-new-redirect';
                }
                ChangeTags::addTags( $redirectTags, null, $redirectRevId, null );
            }
        }
 
        # Log the move
        $logid = $logEntry->insert();
 
        $logEntry->addTags( $changeTags );
        $logEntry->publish( $logid );
 
        return $nullRevision;
    }
}