MediaWiki  master
JavaScriptMinifierTest.php
Go to the documentation of this file.
1 <?php
2 
4 
6 
7  protected function tearDown() {
8  parent::tearDown();
9  // Reset
10  $this->setMaxLineLength( 1000 );
11  }
12 
13  private function setMaxLineLength( $val ) {
14  $classReflect = new ReflectionClass( JavaScriptMinifier::class );
15  $propertyReflect = $classReflect->getProperty( 'maxLineLength' );
16  $propertyReflect->setAccessible( true );
17  $propertyReflect->setValue( JavaScriptMinifier::class, $val );
18  }
19 
20  public static function provideCases() {
21  return [
22 
23  // Basic whitespace and comments that should be stripped entirely
24  [ "\r\t\f \v\n\r", "" ],
25  [ "/* Foo *\n*bar\n*/", "" ],
26 
32  [
33  "/**\n * Foo\n * {\n * 'bar' : {\n * "
34  . "//Multiple rules with configurable operators\n * 'baz' : false\n * }\n */",
35  "" ],
36 
41  [
42  "' Foo \\' bar \\\n baz \\' quox ' .length",
43  "' Foo \\' bar \\\n baz \\' quox '.length"
44  ],
45  [
46  "\" Foo \\\" bar \\\n baz \\\" quox \" .length",
47  "\" Foo \\\" bar \\\n baz \\\" quox \".length"
48  ],
49  [ "// Foo b/ar baz", "" ],
50  [
51  "/ Foo \\/ bar [ / \\] / ] baz / .length",
52  "/ Foo \\/ bar [ / \\] / ] baz /.length"
53  ],
54 
55  // HTML comments
56  [ "<!-- Foo bar", "" ],
57  [ "<!-- Foo --> bar", "" ],
58  [ "--> Foo", "" ],
59  [ "x --> y", "x-->y" ],
60 
61  // Semicolon insertion
62  [ "(function(){return\nx;})", "(function(){return\nx;})" ],
63  [ "throw\nx;", "throw\nx;" ],
64  [ "while(p){continue\nx;}", "while(p){continue\nx;}" ],
65  [ "while(p){break\nx;}", "while(p){break\nx;}" ],
66  [ "var\nx;", "var x;" ],
67  [ "x\ny;", "x\ny;" ],
68  [ "x\n++y;", "x\n++y;" ],
69  [ "x\n!y;", "x\n!y;" ],
70  [ "x\n{y}", "x\n{y}" ],
71  [ "x\n+y;", "x+y;" ],
72  [ "x\n(y);", "x(y);" ],
73  [ "5.\nx;", "5.\nx;" ],
74  [ "0xFF.\nx;", "0xFF.x;" ],
75  [ "5.3.\nx;", "5.3.x;" ],
76 
77  // Cover failure case for incomplete hex literal
78  [ "0x;", false, false ],
79 
80  // Cover failure case for number with no digits after E
81  [ "1.4E", false, false ],
82 
83  // Cover failure case for number with several E
84  [ "1.4EE2", false, false ],
85  [ "1.4EE", false, false ],
86 
87  // Cover failure case for number with several E (nonconsecutive)
88  // FIXME: This is invalid, but currently tolerated
89  [ "1.4E2E3", "1.4E2 E3", false ],
90 
91  // Semicolon insertion between an expression having an inline
92  // comment after it, and a statement on the next line (T29046).
93  [
94  "var a = this //foo bar \n for ( b = 0; c < d; b++ ) {}",
95  "var a=this\nfor(b=0;c<d;b++){}"
96  ],
97 
98  // Cover failure case of incomplete regexp at end of file (T75556)
99  // FIXME: This is invalid, but currently tolerated
100  [ "*/", "*/", false ],
101 
102  // Cover failure case of incomplete char class in regexp (T75556)
103  // FIXME: This is invalid, but currently tolerated
104  [ "/a[b/.test", "/a[b/.test", false ],
105 
106  // Cover failure case of incomplete string at end of file (T75556)
107  // FIXME: This is invalid, but currently tolerated
108  [ "'a", "'a", false ],
109 
110  // Token separation
111  [ "x in y", "x in y" ],
112  [ "/x/g in y", "/x/g in y" ],
113  [ "x in 30", "x in 30" ],
114  [ "x + ++ y", "x+ ++y" ],
115  [ "x ++ + y", "x++ +y" ],
116  [ "x / /y/.exec(z)", "x/ /y/.exec(z)" ],
117 
118  // State machine
119  [ "/ x/g", "/ x/g" ],
120  [ "(function(){return/ x/g})", "(function(){return/ x/g})" ],
121  [ "+/ x/g", "+/ x/g" ],
122  [ "++/ x/g", "++/ x/g" ],
123  [ "x/ x/g", "x/x/g" ],
124  [ "(/ x/g)", "(/ x/g)" ],
125  [ "if(/ x/g);", "if(/ x/g);" ],
126  [ "(x/ x/g)", "(x/x/g)" ],
127  [ "([/ x/g])", "([/ x/g])" ],
128  [ "+x/ x/g", "+x/x/g" ],
129  [ "{}/ x/g", "{}/ x/g" ],
130  [ "+{}/ x/g", "+{}/x/g" ],
131  [ "(x)/ x/g", "(x)/x/g" ],
132  [ "if(x)/ x/g", "if(x)/ x/g" ],
133  [ "for(x;x;{}/ x/g);", "for(x;x;{}/x/g);" ],
134  [ "x;x;{}/ x/g", "x;x;{}/ x/g" ],
135  [ "x:{}/ x/g", "x:{}/ x/g" ],
136  [ "switch(x){case y?z:{}/ x/g:{}/ x/g;}", "switch(x){case y?z:{}/x/g:{}/ x/g;}" ],
137  [ "function x(){}/ x/g", "function x(){}/ x/g" ],
138  [ "+function x(){}/ x/g", "+function x(){}/x/g" ],
139 
140  // Multiline quoted string
141  [ "var foo=\"\\\nblah\\\n\";", "var foo=\"\\\nblah\\\n\";" ],
142 
143  // Multiline quoted string followed by string with spaces
144  [
145  "var foo=\"\\\nblah\\\n\";\nvar baz = \" foo \";\n",
146  "var foo=\"\\\nblah\\\n\";var baz=\" foo \";"
147  ],
148 
149  // URL in quoted string ( // is not a comment)
150  [
151  "aNode.setAttribute('href','http://foo.bar.org/baz');",
152  "aNode.setAttribute('href','http://foo.bar.org/baz');"
153  ],
154 
155  // URL in quoted string after multiline quoted string
156  [
157  "var foo=\"\\\nblah\\\n\";\naNode.setAttribute('href','http://foo.bar.org/baz');",
158  "var foo=\"\\\nblah\\\n\";aNode.setAttribute('href','http://foo.bar.org/baz');"
159  ],
160 
161  // Division vs. regex nastiness
162  [
163  "alert( (10+10) / '/'.charCodeAt( 0 ) + '//' );",
164  "alert((10+10)/'/'.charCodeAt(0)+'//');"
165  ],
166  [ "if(1)/a /g.exec('Pa ss');", "if(1)/a /g.exec('Pa ss');" ],
167 
168  // Unicode letter characters should pass through ok in identifiers (T33187)
169  [ "var KaĊSkatolVal = {}", 'var KaĊSkatolVal={}' ],
170 
171  // Per spec unicode char escape values should work in identifiers,
172  // as long as it's a valid char. In future it might get normalized.
173  [ "var Ka\\u015dSkatolVal = {}", 'var Ka\\u015dSkatolVal={}' ],
174 
175  // Some structures that might look invalid at first sight
176  [ "var a = 5.;", "var a=5.;" ],
177  [ "5.0.toString();", "5.0.toString();" ],
178  [ "5..toString();", "5..toString();" ],
179  // Cover failure case for too many decimal points
180  [ "5...toString();", false ],
181  [ "5.\n.toString();", '5..toString();' ],
182 
183  // Boolean minification (!0 / !1)
184  [ "var a = { b: true };", "var a={b:!0};" ],
185  [ "var a = { true: 12 };", "var a={true:12};" ],
186  [ "a.true = 12;", "a.true=12;" ],
187  [ "a.foo = true;", "a.foo=!0;" ],
188  [ "a.foo = false;", "a.foo=!1;" ],
189  ];
190  }
191 
197  public function testMinifyOutput( $code, $expectedOutput, $expectedValid = true ) {
198  $minified = JavaScriptMinifier::minify( $code );
199 
200  // JSMin+'s parser will throw an exception if output is not valid JS.
201  // suppression of warnings needed for stupid crap
202  if ( $expectedValid ) {
203  Wikimedia\suppressWarnings();
204  $parser = new JSParser();
205  Wikimedia\restoreWarnings();
206  $parser->parse( $minified, 'minify-test.js', 1 );
207  }
208 
209  $this->assertEquals(
210  $expectedOutput,
211  $minified,
212  "Minified output should be in the form expected."
213  );
214  }
215 
216  public static function provideLineBreaker() {
217  return [
218  [
219  // Regression tests for T34548.
220  // Must not break between 'E' and '+'.
221  'var name = 1.23456789E55;',
222  [
223  'var',
224  'name',
225  '=',
226  '1.23456789E55',
227  ';',
228  ],
229  ],
230  [
231  'var name = 1.23456789E+5;',
232  [
233  'var',
234  'name',
235  '=',
236  '1.23456789E+5',
237  ';',
238  ],
239  ],
240  [
241  'var name = 1.23456789E-5;',
242  [
243  'var',
244  'name',
245  '=',
246  '1.23456789E-5',
247  ';',
248  ],
249  ],
250  [
251  // Must not break before '++'
252  'if(x++);',
253  [
254  'if',
255  '(',
256  'x++',
257  ')',
258  ';',
259  ],
260  ],
261  [
262  // Regression test for T201606.
263  // Must not break between 'return' and Expression.
264  // Was caused by bad state after '{}' in property value.
265  <<<JAVASCRIPT
266  call( function () {
267  try {
268  } catch (e) {
269  obj = {
270  key: 1 ? 0 : {}
271  };
272  }
273  return name === 'input';
274  } );
275 JAVASCRIPT
276  ,
277  [
278  'call',
279  '(',
280  'function',
281  '(',
282  ')',
283  '{',
284  'try',
285  '{',
286  '}',
287  'catch',
288  '(',
289  'e',
290  ')',
291  '{',
292  'obj',
293  '=',
294  '{',
295  'key',
296  ':',
297  '1',
298  '?',
299  '0',
300  ':',
301  '{',
302  '}',
303  '}',
304  ';',
305  '}',
306  // The return Statement:
307  // return [no LineTerminator here] Expression
308  'return name',
309  '===',
310  "'input'",
311  ';',
312  '}',
313  ')',
314  ';',
315  ]
316  ],
317  [
318  // Regression test for T201606.
319  // Must not break between 'return' and Expression.
320  // Was caused by bad state after a ternary in the expression value
321  // for a key in an object literal.
322  <<<JAVASCRIPT
323 call( {
324  key: 1 ? 0 : function () {
325  return this;
326  }
327 } );
328 JAVASCRIPT
329  ,
330  [
331  'call',
332  '(',
333  '{',
334  'key',
335  ':',
336  '1',
337  '?',
338  '0',
339  ':',
340  'function',
341  '(',
342  ')',
343  '{',
344  'return this',
345  ';',
346  '}',
347  '}',
348  ')',
349  ';',
350  ]
351  ],
352  ];
353  }
354 
359  public function testLineBreaker( $code, array $expectedLines ) {
360  $this->setMaxLineLength( 1 );
361  $actual = JavaScriptMinifier::minify( $code );
362  $this->assertEquals(
363  array_merge( [ '' ], $expectedLines ),
364  explode( "\n", $actual )
365  );
366  }
367 }
processing should stop and the error should be shown to the user * false
Definition: hooks.txt:187
Apache License January AND DISTRIBUTION Definitions License shall mean the terms and conditions for use
either a unescaped string or a HtmlArmor object after in associative array form externallinks including delete and has completed for all link tables whether this was an auto creation use $formDescriptor instead default is conds Array Extra conditions for the No matching items in log is displayed if loglist is empty msgKey Array If you want a nice box with a set this to the key of the message First element is the message key
Definition: hooks.txt:2151
in this case you re responsible for computing and outputting the entire conflict i e
Definition: hooks.txt:1420
see documentation in includes Linker php for Linker::makeImageLink or false for current used if you return false $parser
Definition: hooks.txt:1799
and how to run hooks for an and one after Each event has a name
Definition: hooks.txt:6
testMinifyOutput( $code, $expectedOutput, $expectedValid=true)
provideCases JavaScriptMinifier::minify JavaScriptMinifier::parseError
this hook is for auditing only or null if authentication failed before getting that far or null if we can t even determine that When $user is not it can be in the form of< username >< more info > e g for bot passwords intended to be added to log contexts Fields it might only if the login was with a bot password it is not rendered in wiki pages or galleries in category pages allow injecting custom HTML after the section Any uses of the hook need to handle escaping see BaseTemplate::getToolbox and BaseTemplate::makeListItem for details on the format of individual items inside of this array or by returning and letting standard HTTP rendering take place modifiable or by returning false and taking over the output modifiable & $code
Definition: hooks.txt:780
testLineBreaker( $code, array $expectedLines)
provideLineBreaker JavaScriptMinifier::minify
injection txt This is an overview of how MediaWiki makes use of dependency injection The design described here grew from the discussion of RFC T384 The term dependency this means that anything an object needs to operate should be injected from the the object itself should only know narrow no concrete implementation of the logic it relies on The requirement to inject everything typically results in an architecture that based on two main types of and essentially stateless service objects that use other service objects to operate on the value objects As of the beginning MediaWiki is only starting to use the DI approach Much of the code still relies on global state or direct resulting in a highly cyclical dependency which acts as the top level factory for services in MediaWiki which can be used to gain access to default instances of various services MediaWikiServices however also allows new services to be defined and default services to be redefined Services are defined or redefined by providing a callback the instantiator that will return a new instance of the service When it will create an instance of MediaWikiServices and populate it with the services defined in the files listed by thereby bootstrapping the DI framework Per $wgServiceWiringFiles lists includes ServiceWiring php
Definition: injection.txt:35
you have access to all of the normal MediaWiki so you can get a DB use the etc For full docs on the Maintenance class
Definition: maintenance.txt:52
static minify( $s)
Returns minified JavaScript code.