MediaWiki  1.29.1
JavaScriptMinifierTest.php
Go to the documentation of this file.
1 <?php
2 
3 class JavaScriptMinifierTest extends PHPUnit_Framework_TestCase {
4 
5  public static function provideCases() {
6  return [
7 
8  // Basic whitespace and comments that should be stripped entirely
9  [ "\r\t\f \v\n\r", "" ],
10  [ "/* Foo *\n*bar\n*/", "" ],
11 
17  [
18  "/**\n * Foo\n * {\n * 'bar' : {\n * "
19  . "//Multiple rules with configurable operators\n * 'baz' : false\n * }\n */",
20  "" ],
21 
26  [
27  "' Foo \\' bar \\\n baz \\' quox ' .length",
28  "' Foo \\' bar \\\n baz \\' quox '.length"
29  ],
30  [
31  "\" Foo \\\" bar \\\n baz \\\" quox \" .length",
32  "\" Foo \\\" bar \\\n baz \\\" quox \".length"
33  ],
34  [ "// Foo b/ar baz", "" ],
35  [
36  "/ Foo \\/ bar [ / \\] / ] baz / .length",
37  "/ Foo \\/ bar [ / \\] / ] baz /.length"
38  ],
39 
40  // HTML comments
41  [ "<!-- Foo bar", "" ],
42  [ "<!-- Foo --> bar", "" ],
43  [ "--> Foo", "" ],
44  [ "x --> y", "x-->y" ],
45 
46  // Semicolon insertion
47  [ "(function(){return\nx;})", "(function(){return\nx;})" ],
48  [ "throw\nx;", "throw\nx;" ],
49  [ "while(p){continue\nx;}", "while(p){continue\nx;}" ],
50  [ "while(p){break\nx;}", "while(p){break\nx;}" ],
51  [ "var\nx;", "var x;" ],
52  [ "x\ny;", "x\ny;" ],
53  [ "x\n++y;", "x\n++y;" ],
54  [ "x\n!y;", "x\n!y;" ],
55  [ "x\n{y}", "x\n{y}" ],
56  [ "x\n+y;", "x+y;" ],
57  [ "x\n(y);", "x(y);" ],
58  [ "5.\nx;", "5.\nx;" ],
59  [ "0xFF.\nx;", "0xFF.x;" ],
60  [ "5.3.\nx;", "5.3.x;" ],
61 
62  // Semicolon insertion between an expression having an inline
63  // comment after it, and a statement on the next line (T29046).
64  [
65  "var a = this //foo bar \n for ( b = 0; c < d; b++ ) {}",
66  "var a=this\nfor(b=0;c<d;b++){}"
67  ],
68 
69  // Token separation
70  [ "x in y", "x in y" ],
71  [ "/x/g in y", "/x/g in y" ],
72  [ "x in 30", "x in 30" ],
73  [ "x + ++ y", "x+ ++y" ],
74  [ "x ++ + y", "x++ +y" ],
75  [ "x / /y/.exec(z)", "x/ /y/.exec(z)" ],
76 
77  // State machine
78  [ "/ x/g", "/ x/g" ],
79  [ "(function(){return/ x/g})", "(function(){return/ x/g})" ],
80  [ "+/ x/g", "+/ x/g" ],
81  [ "++/ x/g", "++/ x/g" ],
82  [ "x/ x/g", "x/x/g" ],
83  [ "(/ x/g)", "(/ x/g)" ],
84  [ "if(/ x/g);", "if(/ x/g);" ],
85  [ "(x/ x/g)", "(x/x/g)" ],
86  [ "([/ x/g])", "([/ x/g])" ],
87  [ "+x/ x/g", "+x/x/g" ],
88  [ "{}/ x/g", "{}/ x/g" ],
89  [ "+{}/ x/g", "+{}/x/g" ],
90  [ "(x)/ x/g", "(x)/x/g" ],
91  [ "if(x)/ x/g", "if(x)/ x/g" ],
92  [ "for(x;x;{}/ x/g);", "for(x;x;{}/x/g);" ],
93  [ "x;x;{}/ x/g", "x;x;{}/ x/g" ],
94  [ "x:{}/ x/g", "x:{}/ x/g" ],
95  [ "switch(x){case y?z:{}/ x/g:{}/ x/g;}", "switch(x){case y?z:{}/x/g:{}/ x/g;}" ],
96  [ "function x(){}/ x/g", "function x(){}/ x/g" ],
97  [ "+function x(){}/ x/g", "+function x(){}/x/g" ],
98 
99  // Multiline quoted string
100  [ "var foo=\"\\\nblah\\\n\";", "var foo=\"\\\nblah\\\n\";" ],
101 
102  // Multiline quoted string followed by string with spaces
103  [
104  "var foo=\"\\\nblah\\\n\";\nvar baz = \" foo \";\n",
105  "var foo=\"\\\nblah\\\n\";var baz=\" foo \";"
106  ],
107 
108  // URL in quoted string ( // is not a comment)
109  [
110  "aNode.setAttribute('href','http://foo.bar.org/baz');",
111  "aNode.setAttribute('href','http://foo.bar.org/baz');"
112  ],
113 
114  // URL in quoted string after multiline quoted string
115  [
116  "var foo=\"\\\nblah\\\n\";\naNode.setAttribute('href','http://foo.bar.org/baz');",
117  "var foo=\"\\\nblah\\\n\";aNode.setAttribute('href','http://foo.bar.org/baz');"
118  ],
119 
120  // Division vs. regex nastiness
121  [
122  "alert( (10+10) / '/'.charCodeAt( 0 ) + '//' );",
123  "alert((10+10)/'/'.charCodeAt(0)+'//');"
124  ],
125  [ "if(1)/a /g.exec('Pa ss');", "if(1)/a /g.exec('Pa ss');" ],
126 
127  // newline insertion after 1000 chars: break after the "++", not before
128  [ str_repeat( ';', 996 ) . "if(x++);", str_repeat( ';', 996 ) . "if(x++\n);" ],
129 
130  // Unicode letter characters should pass through ok in identifiers (T33187)
131  [ "var KaĊSkatolVal = {}", 'var KaĊSkatolVal={}' ],
132 
133  // Per spec unicode char escape values should work in identifiers,
134  // as long as it's a valid char. In future it might get normalized.
135  [ "var Ka\\u015dSkatolVal = {}", 'var Ka\\u015dSkatolVal={}' ],
136 
137  // Some structures that might look invalid at first sight
138  [ "var a = 5.;", "var a=5.;" ],
139  [ "5.0.toString();", "5.0.toString();" ],
140  [ "5..toString();", "5..toString();" ],
141  [ "5...toString();", false ],
142  [ "5.\n.toString();", '5..toString();' ],
143 
144  // Boolean minification (!0 / !1)
145  [ "var a = { b: true };", "var a={b:!0};" ],
146  [ "var a = { true: 12 };", "var a={true:12};", false ],
147  [ "a.true = 12;", "a.true=12;", false ],
148  [ "a.foo = true;", "a.foo=!0;" ],
149  [ "a.foo = false;", "a.foo=!1;" ],
150  ];
151  }
152 
157  public function testJavaScriptMinifierOutput( $code, $expectedOutput, $expectedValid = true ) {
158  $minified = JavaScriptMinifier::minify( $code );
159 
160  // JSMin+'s parser will throw an exception if output is not valid JS.
161  // suppression of warnings needed for stupid crap
162  if ( $expectedValid ) {
163  MediaWiki\suppressWarnings();
164  $parser = new JSParser();
165  MediaWiki\restoreWarnings();
166  $parser->parse( $minified, 'minify-test.js', 1 );
167  }
168 
169  $this->assertEquals(
170  $expectedOutput,
171  $minified,
172  "Minified output should be in the form expected."
173  );
174  }
175 
176  public static function provideExponentLineBreaking() {
177  return [
178  [
179  // This one gets interpreted all together by the prior code;
180  // no break at the 'E' happens.
181  '1.23456789E55',
182  ],
183  [
184  // This one breaks under the bad code; splits between 'E' and '+'
185  '1.23456789E+5',
186  ],
187  [
188  // This one breaks under the bad code; splits between 'E' and '-'
189  '1.23456789E-5',
190  ],
191  ];
192  }
193 
198  public function testExponentLineBreaking( $num ) {
199  // Long line breaking was being incorrectly done between the base and
200  // exponent part of a number, causing a syntax error. The line should
201  // instead break at the start of the number. (T34548)
202  $prefix = 'var longVarName' . str_repeat( '_', 973 ) . '=';
203  $suffix = ',shortVarName=0;';
204 
205  $input = $prefix . $num . $suffix;
206  $expected = $prefix . "\n" . $num . $suffix;
207 
208  $minified = JavaScriptMinifier::minify( $input );
209 
210  $this->assertEquals( $expected, $minified, "Line breaks must not occur in middle of exponent" );
211  }
212 }
JavaScriptMinifierTest
Definition: JavaScriptMinifierTest.php:3
false
processing should stop and the error should be shown to the user * false
Definition: hooks.txt:189
JavaScriptMinifierTest\testJavaScriptMinifierOutput
testJavaScriptMinifierOutput( $code, $expectedOutput, $expectedValid=true)
provideCases JavaScriptMinifier::minify
Definition: JavaScriptMinifierTest.php:157
JavaScriptMinifier\minify
static minify( $s, $statementsOnOwnLine=false, $maxLineLength=1000)
Returns minified JavaScript code.
Definition: JavaScriptMinifier.php:81
JavaScriptMinifierTest\testExponentLineBreaking
testExponentLineBreaking( $num)
provideExponentLineBreaking JavaScriptMinifier::minify
Definition: JavaScriptMinifierTest.php:198
php
injection txt This is an overview of how MediaWiki makes use of dependency injection The design described here grew from the discussion of RFC T384 The term dependency this means that anything an object needs to operate should be injected from the the object itself should only know narrow no concrete implementation of the logic it relies on The requirement to inject everything typically results in an architecture that based on two main types of and essentially stateless service objects that use other service objects to operate on the value objects As of the beginning MediaWiki is only starting to use the DI approach Much of the code still relies on global state or direct resulting in a highly cyclical dependency which acts as the top level factory for services in MediaWiki which can be used to gain access to default instances of various services MediaWikiServices however also allows new services to be defined and default services to be redefined Services are defined or redefined by providing a callback the instantiator that will return a new instance of the service When it will create an instance of MediaWikiServices and populate it with the services defined in the files listed by thereby bootstrapping the DI framework Per $wgServiceWiringFiles lists includes ServiceWiring php
Definition: injection.txt:35
JavaScriptMinifierTest\provideExponentLineBreaking
static provideExponentLineBreaking()
Definition: JavaScriptMinifierTest.php:176
$input
if(is_array( $mode)) switch( $mode) $input
Definition: postprocess-phan.php:141
$parser
do that in ParserLimitReportFormat instead $parser
Definition: hooks.txt:2536
JavaScriptMinifierTest\provideCases
static provideCases()
Definition: JavaScriptMinifierTest.php:5
$code
this hook is for auditing only or null if authentication failed before getting that far or null if we can t even determine that probably a stub it is not rendered in wiki pages or galleries in category pages allow injecting custom HTML after the section Any uses of the hook need to handle escaping see BaseTemplate::getToolbox and BaseTemplate::makeListItem for details on the format of individual items inside of this array or by returning and letting standard HTTP rendering take place modifiable or by returning false and taking over the output modifiable & $code
Definition: hooks.txt:783
JSParser
Definition: jsminplus.php:674